Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm README #100

Closed
zeg-io opened this issue Dec 18, 2018 · 8 comments
Closed

npm README #100

zeg-io opened this issue Dec 18, 2018 · 8 comments

Comments

@zeg-io
Copy link

zeg-io commented Dec 18, 2018

The NPM readme for this module states there is a XSS vulnerability, however this readme is different, and the npm audit shows no vulnerabilities.

Was the issue resolved and just not republished to npm or is the issue still there but no longer in this readme?

@pvorb
Copy link
Owner

pvorb commented Dec 19, 2018

The vulnerability was fixed in 1.0.4. I removed the note about the vulnerability in 98dc28c. It's still on npm because there was no new release since that commit. Only releases <= 1.0.3 are marked to be vulnerable and would be found by npm audit.

Does that answer your question?

@hiendv
Copy link

hiendv commented Sep 25, 2019

@pvorb Pardon me, how is it "no new release since that commit"? The latest release is 2.1.2 but the npm's README is outdated?

@pvorb
Copy link
Owner

pvorb commented Sep 25, 2019

That commit was after the 2.1.2 release.

@hiendv
Copy link

hiendv commented Sep 25, 2019

Got it. I thought the commit's somewhere between 1.0.4 and 2.1.2 🤣

@pvorb
Copy link
Owner

pvorb commented Sep 25, 2019

Yeah, no worries. I had to revisit the commit history to make sure I wasn't wrong.

@jayaddison
Copy link

The text 'XSS Vulnerability Detected' appears on the npmjs page for clone at the moment, as part of the readme (just before the 'Installation' heading). Is that the same issue as reported here?

@pvorb
Copy link
Owner

pvorb commented Jul 17, 2020

Yes

@gubo
Copy link

gubo commented Feb 26, 2021

hi ... may i ask what the xss vulnerability was due to, and what was the fix ? i cant seem to find the fix in the commits ...
thanks much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants