Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add utility to strip source maps #391

Merged
merged 1 commit into from
Nov 22, 2022
Merged

feat: add utility to strip source maps #391

merged 1 commit into from
Nov 22, 2022

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Nov 22, 2022

No description provided.

@OrKoN OrKoN force-pushed the feat-strip-sourcemap branch from dd0e6ab to 76ad757 Compare November 22, 2022 08:42
Lightning00Blade
Lightning00Blade approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@Lightning00Blade Lightning00Blade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but would it make sense to also add an option to not generate it during stringification?

@OrKoN OrKoN force-pushed the feat-strip-sourcemap branch from 76ad757 to d6e7de4 Compare November 22, 2022 08:49
@OrKoN
Copy link
Collaborator Author

OrKoN commented Nov 22, 2022

Looks good, but would it make sense to also add an option to not generate it during stringification?

I think it would be unnecessary because stripping it is better than generating the file two times.

@OrKoN OrKoN enabled auto-merge (squash) November 22, 2022 08:50
@OrKoN OrKoN force-pushed the feat-strip-sourcemap branch from d6e7de4 to 52bb8bf Compare November 22, 2022 08:51
@OrKoN OrKoN merged commit 179d8f4 into main Nov 22, 2022
@OrKoN OrKoN deleted the feat-strip-sourcemap branch November 22, 2022 08:57
@release-please release-please bot mentioned this pull request Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lightning00Blade Lightning00Blade Lightning00Blade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrKoN @Lightning00Blade