Missing dependency: lighthouse

[rlaffers]

Expected Behavior

The @puppeteer/replay is compiled without errors when it is installed as a dependency.

Actual Behavior

An error occurs when I bundle my app:

[vite]: Rollup failed to resolve import "lighthouse/core/fraggle-rock/api.js" from "node_modules/@puppeteer/replay/lib/main.js".

This is due to lighthouse missing from the dependencies and/or peerDependencies in package.json. lighthouse is listed only as a devDependency, while in fact it is a normal dependency since the library source depends on it.

Steps to Reproduce the Problem

1. npm create vite@latest my-app -- --template vanilla
2. cd my-app && npm install
3. npm install --save @puppeteer/replay
4. Import from @puppeteer/replay in the main.js file:
   import { PuppeteerRunnerExtension } from '@puppeteer/replay'
5. npm run build

Specifications

• Version: @puppeteer/[email protected], node 16.18.0
• Platform: Linux

[OrKoN]

@adamraine could you please take a look?

[adamraine]

So we prevent Lighthouse from being bundled using rollup externals:

replay/rollup.config.cjs

Line 20 in 961965e

external: [...Object.keys(pkg.peerDependencies), /^lighthouse/],

I would expect tree shaking prevent rollup from using LighthouseRunnerExtension and therefore remove the need to import Lighthouse.

In any case, we should remove the lighthouse runner extension from the main bundle. Eventually we will make Lighthouse a peer dependency, but Lighthouse needs a lot of work with rollup plugins to work in bundled environments. If rollup can't automatically trim the Lighthouse import statements, maybe we should add a separate import path for Lighthouse like @puppeteer/replay/lighthouse.