feat: add Lighthouse runner extension #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Aug 31, 2022
Comment on lines
+81
to
+90
| const lighthouseExtension = new LighthouseRunnerExtension(browser, page); | ||
| const runner = await createRunner(flow, lighthouseExtension); | ||
| const result = await runner.run(); | ||
|
|
||
| await page.close(); | ||
| await browser.close(); | ||
|
|
||
| assert.ok(result); | ||
|
|
||
| return lighthouseExtension.createFlowResult(); |
There was a problem hiding this comment.
We need to get some secondary result from the extension and this method made the most sense to me.
Another option is to add an onFlowResultCreated callback to the extension constructor or something.
OrKoN
reviewed
Sep 1, 2022
OrKoN
reviewed
Sep 8, 2022
OrKoN
approved these changes
Sep 14, 2022
|
I think this is good to land if we remove the peer dependency stuff. We can add the peer dependency stuff back once LH 10.0 releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't merge this until LH 10.0 is released, but can still discuss until then.