feat: Lighthouse stringify extension #272
Merged
+2,017
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Aug 22, 2022
| @@ -56,6 +56,7 @@ | |||
| "eslint-config-prettier": "8.5.0", | |||
| "eslint-plugin-prettier": "4.0.0", | |||
| "eslint-plugin-tsdoc": "0.2.16", | |||
| "lighthouse": "9.5.0-dev.20220818", | |||
There was a problem hiding this comment.
The output scripts require features in LH 10.0. This dep is only used for testing so it should be fine to use a preview build.
OrKoN
reviewed
Aug 23, 2022
| extension: new LighthouseStringifyExtension(), | ||
| }); | ||
|
|
||
| // Trim the output to the relevant stuff |
There was a problem hiding this comment.
should we extract a helper function for trimming? Also, perhaps, it's better to search for await browser.close() to avoid the dangling await in the snapshot?
OrKoN
reviewed
Aug 23, 2022
| assert.strictEqual(stdout, ''); | ||
| assert.strictEqual(stderr, ''); | ||
|
|
||
| const reportHtml = fs.readFileSync( |
There was a problem hiding this comment.
this is nice! we need to do that for the regular stringify extension and combine it with #268 to have better coverage
OrKoN
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be pretty much the same as GoogleChrome/lighthouse#14146
FWIW I think some version of the e2e tester could be useful for the more generic
PuppeteerStringifyExtension. The e2e tester is what helped me catch the bug from #261.