-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: run all recording files in directory with cli #184
Conversation
b86f927
to
00de504
Compare
Hey, thanks for the PR. It looks like some tests are failing. Also I have been wondering if the shell filename expansion would work? Basically, the following already works in shells:
|
00de504
to
f890bad
Compare
f890bad
to
d57b6e2
Compare
bbf54e8
to
b780531
Compare
Thank you for the feedback @OrKoN. I updated the PR and now all the tests pass. 💃 Yes, shell filename expansion works. But when you want to run a folder with different files(like we have in /test/resources) you should give the extension as well. npx @puppeteer/replay replay/*.json With my pr it's easier. You just need to run the command below. It'll only run JSON files in the folder. npx @puppeteer/replay replay If you think using shell filename expansion is a better approach, we should update the README. 🙏 |
b780531
to
68f7868
Compare
I saw the problem with Windows paths and I fixed it 🙏 |
68f7868
to
8f5815b
Compare
Sounds good, could you please update the README with this? I think the code looks good. |
Thank you @OrKoN ! I updated the README with this. You can check the last commit 🙏 |
Head branch was pushed to by a user without write access
a14c872
to
4e24589
Compare
There was a code style issue on README and I fixed it. Can you run GH actions again? @OrKoN |
Implements #183