-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix attribute interpolation using quotes #179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to work 🎉
Really much ❤️ to you for fixing this really old issue 😃
I think you will make many devs in our community happy with that!
One more thing you can do is removing all the parts that addressing this workaround like in the README.md
I will update the changelog on my own and managing the next version number, so you don't need to check for these.
Oh, and one more thing that would be cool: Could you write inline comments or improve the JSDoc for the function to address this improved special behavior? |
First, thanks for quick review:) I'll try to work on things you've said! |
@Cloudless67 I'm currently in some meetings and think I can create a release todays evening A little minor change you could make is correcting the capital typo in the comment
|
This is fix for issue #58.