-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix counting of current line-length #121
Fix counting of current line-length #121
Conversation
I really like the For an in depth review, I need more (free-)time 🙂 |
Thanks! The function relies on state on the |
Sorry for the merge conflicts, cannot resolve them on my side 🙁 |
No worries! Will resolve later! |
5fd5178
to
5d5c64a
Compare
@Shinigami92 I've rebased the changes in this branch on top of master, resolving all the conflicts, and force-pushed a new version. I hope that's fine! |
@lehni I hope I'm not to deep into "how I organize PRs", but is this feature merge ready? |
So it works correctly with the various settings of attributeSeparator
fb82843
to
1db2e1c
Compare
Add comments explaining the handling of literal attributes and normal ones
1db2e1c
to
deff459
Compare
@Shinigami92 when looking into the handling of literal attributes, I found a new bug in the current implementation of the plugin that happens as soon as you have both an id and class attribute on an element. I already have a fix for this in a follow up PR, but it will require #121 to be merged first. And I don't want to include it here, to not complicate this PR further. |
I noticed that the current line-length wasn't counted correctly depending on the setting of attributeSeparator.
This PR fixes that and adds tests for the various settings.