TimeRange - Allow specifying arrayOfWeekdays

[anton-johansson]

Is your feature request related to a problem? Please describe.
I want to Monday to be the first row instead of Sunday.

Describe the solution you'd like
Should be easy to allow passing in arrayOfWeekdays as a property to TimeRange that is passed down to computeWeekdays:

nivo/packages/calendar/src/TimeRange.tsx

Line 114 in d49a790

const weekdayLegends = computeWeekdays({

Or maybe more clean: A property to indicate which is the first day of the week.

Describe alternatives you've considered
None.

[plouc]

@anton-johansson, if you think the solution is easy to implement, please do not hesitate to submit a PR ;)

[aried3r]

@plouc, what do you think about #613?

[anton-johansson]

I'll try to get the project set up locally and see what I can do. I'd guess "first day of the week" is the cleanest approach?

[anton-johansson]

Won't be as easy as I initially thought! I looked too fast, arrayOfWeekdays is just for the labels. But I need to be able to specify those as well (I want to translate them in the appropriate language), so I might attempt to fix both of those issues in the same PR.

[aried3r]

@anton-johansson, in case #613 solves the problem of the first-day-of-the-week problem (I haven't checked out and run the code in the PR), translation for the calendar component should be doable using monthLegend (see docs). For example using the .toLocaleString() API or other Intl APIs, depending on which browsers you support.

I.e.:

const date = new Date()
const month = date.toLocaleString('it-IT', { month: 'long' });
console.debug(month) // Prints "settembre"

[stale]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

[stale]

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!