Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cache key issue #3190

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix cache key issue #3190

wants to merge 3 commits into from
+16 −4

Conversation

MartinSA04
Copy link

@MartinSA04 MartinSA04 commented Feb 25, 2025 •
edited
Loading

Proposed fix for issue #3189
Closes #3189

Adds triggered_inputs as additional basis for cache_key generation.

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • fix issue
    • add as optional parameter
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR (unsure if this is needed?)

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

@gvwilson gvwilson added feature something new P2 considered for next cycle community community contribution labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson Awaiting requested review from alexcjohnson alexcjohnson is a code owner

@T4rk1n T4rk1n Awaiting requested review from T4rk1n T4rk1n is a code owner

@ndrezn ndrezn Awaiting requested review from ndrezn ndrezn is a code owner

@gvwilson gvwilson Awaiting requested review from gvwilson gvwilson is a code owner

@emilykl emilykl Awaiting requested review from emilykl emilykl is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@T4rk1n T4rk1n

Labels
community community contribution feature something new P2 considered for next cycle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Issue with cache key edge case
3 participants
@MartinSA04 @gvwilson @T4rk1n