Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes set_props to merge instead of overwriting props #3182

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Raahul-Singh
Copy link

@Raahul-Singh Raahul-Singh commented Feb 21, 2025

Start with a description of this PR. Then edit the list below to the items that make sense for your PR scope, and check off the boxes as you go!

Fixes #3104

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • Fix _set_props inside _make_job_fn to accumulate updates instead of overwriting.
    • Ensure all set_props calls persist across multiple updates.
    • Test multiple set_props calls in a background callback to confirm the fix.
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentio

ned the relevant URLS as follows
- [ ] this GitHub #PR number updates the dash docs
- [ ] here is the show and tell thread in Plotly Dash community

This change gets the expected behavior in @faulty13' snippet

Screen.Recording.2025-02-21.at.11.36.25.PM.mov

Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for diskcache, we need the same behavior in regular callbacks, diskcache and celery.

Also need to add tests for the merging.

@gvwilson gvwilson added P2 considered for next cycle fix fixes something broken community community contribution labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution fix fixes something broken P2 considered for next cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set_props only updating last output in background callbacks
3 participants