Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Submission Workflow] | External Review, Author cannot upload revisions in external review stage #11124

Open
1 task done
mbakioglu opened this issue Mar 18, 2025 · 3 comments
Assignees
Labels
Bug:2:Major A bug found in common paths that reduces functionality for a large number of users
Milestone

Comments

@mbakioglu
Copy link

Valid Title

  • I have updated the title to accurately reflect the bug description

Description

Test: Take a new submission through the internal and external review stages
Status: Failed

Description:
The submission progresses through the external review stage as expected. After the Press Editor requests a revision, the author can submit revisions. However, if the author uploads a revision of an existing file, they cannot submit.
Error: "The current role does not have access to this operation."

After encountering this error, the author cannot change the "If you are uploading a revision of an existing file, please indicate which file" option. The author has to cancel and return to the upload page to submit the revision.

*Steps 10-14 (described below) could not be reproduced on the third trial.

#11123

Steps to Reproduce

  1. Log in as a Press Editor.
  2. Request a revision while the submission is in the external review stage.
  3. Log in as the Author.
  4. View the revision request notification and the “Submit Revision” option.
  5. Go to submission.
  6. Click “upload revision”
  7. Notice the error message: "You are not allowed to add and edit these files."
  8. Go to the Revisions Uploaded section and click Upload.
  9. Attempt to upload a file as a revision of an existing file
  10. See the error message: "The current role does not have access to this operation."
  11. Try selecting "This is not a revision of an existing file."
  12. Notice that the screen freezes.
  13. Cancel and return to the upload page.
  14. Attempt to submit the revision as "This is not a revision of an existing file."

Expected Result

The author should be able to submit their revisions either via the button on the dashboard or through the submission screen.
The author should be able to submit a file as a revision of an existing file.
After selecting 'This is a revision of an existing file' the screen should not freeze and let the author change the upload type.

Actual Result

The author cannot submit their revisions either via the button on the dashboard or through the submission screen.
The author cannot submit a file as a revision of an existing file.
After selecting 'This is a revision of an existing file,' the screen freezes and does not allow the author to change the upload type.

Environment Details

No response

Application Version

OMP 3.5

Logs

No response

Additional Information

No response

@mbakioglu mbakioglu changed the title [Main Feature] | Submission Workflow- External Review, Author cannot upload revisions in external review stage Submission Workflow- External Review, Author cannot upload revisions in external review stage Mar 18, 2025
@Tribunal33 Tribunal33 self-assigned this Mar 19, 2025
@Tribunal33 Tribunal33 changed the title Submission Workflow- External Review, Author cannot upload revisions in external review stage [Submission Workflow] | External Review, Author cannot upload revisions in external review stage Mar 19, 2025
@Tribunal33 Tribunal33 added the Bug:2:Major A bug found in common paths that reduces functionality for a large number of users label Mar 19, 2025
@Tribunal33 Tribunal33 modified the milestones: 3.5.0 LTS, 3.5 Internal Mar 19, 2025
@Tribunal33
Copy link
Contributor

I believe it could be part of this added feature #10688. This is why I gave it the interal milestone.

@jardakotesovec
Copy link
Contributor

@Tribunal33 Should be fixed on main/stable35

@Tribunal33
Copy link
Contributor

We will check in RC2. I'm seeing some potential issues. I'm not sure what the requirements are. I will get these confirmed before we attempting more fixes for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:2:Major A bug found in common paths that reduces functionality for a large number of users
Projects
None yet
Development

No branches or pull requests

3 participants