Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different approach #146

Open
bjohansebas opened this issue Feb 1, 2025 · 2 comments
Open

Different approach #146

bjohansebas opened this issue Feb 1, 2025 · 2 comments

Comments

@bjohansebas
Copy link
Contributor

bjohansebas commented Feb 1, 2025

Instead of having to request a GitHub token to push to that branch and create it, why don't we simply clone the repository, change the URL (which is part of what happens when creating a new branch), and run the tests? That way, everything stays local, and we can test this change beyond what the token allows.

The process would be something like this:

  1. The wiby test label is added
  2. The Wiby action runs wiby test
  3. wiby test
  • clones the repository,
  • updates the dependency URL
  • reports the result to GitHub Actions.

I know you're no longer maintaining this project, but @dominykas, can you tell me what you think of this approach?

@dominykas
Copy link
Member

The original idea was to run tests the way the downstream repo would run them, i.e. we want to run it using that repo's actions. The reasoning for that is that generally - yes, all Node.js repos are the same - you npm i && npm t to test them. However sometimes you need additional API keys, or you need to install some OS level dependencies, or you need to run some additional commands (e.g. tsc), or they have a monorepo setup (of which there's at least 3-4 flavors in the wild, and that's before you count the obscure, custom ones). And so a simple clone might no longer suffice - you either need the option to push the branch there or you need to fork the dependent somehow (possible via automation).

But that's the original goal. Maybe it was too ambitious and should not be a goal anymore 😁 It's definitely better to have something working than an unfinished, burnt-out piece of abandonware. It also doesn't have to be an either-or - both approaches can happily coexist via configuration or smth.

@bjohansebas
Copy link
Contributor Author

Yep, I agree, both approaches can coexist. It's good to know why you designed it that way, it gives me a clearer idea of what it was built for and what it could become

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants