You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Instead of having to request a GitHub token to push to that branch and create it, why don't we simply clone the repository, change the URL (which is part of what happens when creating a new branch), and run the tests? That way, everything stays local, and we can test this change beyond what the token allows.
The process would be something like this:
The wiby test label is added
The Wiby action runs wiby test
wiby test
clones the repository,
updates the dependency URL
reports the result to GitHub Actions.
I know you're no longer maintaining this project, but @dominykas, can you tell me what you think of this approach?
The text was updated successfully, but these errors were encountered:
The original idea was to run tests the way the downstream repo would run them, i.e. we want to run it using that repo's actions. The reasoning for that is that generally - yes, all Node.js repos are the same - you npm i && npm t to test them. However sometimes you need additional API keys, or you need to install some OS level dependencies, or you need to run some additional commands (e.g. tsc), or they have a monorepo setup (of which there's at least 3-4 flavors in the wild, and that's before you count the obscure, custom ones). And so a simple clone might no longer suffice - you either need the option to push the branch there or you need to fork the dependent somehow (possible via automation).
But that's the original goal. Maybe it was too ambitious and should not be a goal anymore 😁 It's definitely better to have something working than an unfinished, burnt-out piece of abandonware. It also doesn't have to be an either-or - both approaches can happily coexist via configuration or smth.
Yep, I agree, both approaches can coexist. It's good to know why you designed it that way, it gives me a clearer idea of what it was built for and what it could become
Instead of having to request a GitHub token to push to that branch and create it, why don't we simply clone the repository, change the URL (which is part of what happens when creating a new branch), and run the tests? That way, everything stays local, and we can test this change beyond what the token allows.
The process would be something like this:
wiby test
label is addedwiby test
wiby test
I know you're no longer maintaining this project, but @dominykas, can you tell me what you think of this approach?
The text was updated successfully, but these errors were encountered: