Skip to content

Commit de848df

Browse files
generatedunixname89002005232357facebook-github-bot
generatedunixname89002005232357
authored andcommitted
Revert D44365959: Multisect successfully blamed D44365959 for test or build failures
Summary: This diff is reverting D44365959 Depends on D44372754 D44365959: [litho] Unset view id during unmount by zielinskimz has been identified to be causing the following test or build failures: Tests affected: - [xplat/endtoend/jest-e2e/apps/fb4a/__tests__/composer/media_sharing/fb4aVerifyAddMorePhotoFunctionality-e2e.js](https://www.internalfb.com/intern/test/281475013581802/) Here's the Multisect link: https://www.internalfb.com/multisect/1753941 Here are the tasks that are relevant to this breakage: T131393332: 48 tests started failing for oncall android_sharing in the last 2 weeks We're generating a revert to back out the changes in this diff, please note the backout may land if someone accepts it. Reviewed By: zielinskimz Differential Revision: D44372765 fbshipit-source-id: ced9d020eb327c9678cb998e95447261a51b5deb
1 parent d0bf34e commit de848df

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

litho-core/src/main/java/com/facebook/litho/LithoViewAttributesExtension.java

-8
Original file line numberDiff line numberDiff line change
@@ -299,8 +299,6 @@ static void unsetViewAttributes(
299299
unsetInterceptTouchEventHandler(view);
300300
}
301301

302-
unsetViewId(view);
303-
304302
if (attributes.isTagSet()) {
305303
unsetViewTag(view);
306304
}
@@ -555,12 +553,6 @@ private static void setViewId(View view, @IdRes int id) {
555553
}
556554
}
557555

558-
private static void unsetViewId(View view) {
559-
if (view.getId() != View.NO_ID) {
560-
view.setId(View.NO_ID);
561-
}
562-
}
563-
564556
private static void setViewTag(View view, @Nullable Object viewTag) {
565557
view.setTag(viewTag);
566558
}

0 commit comments

Comments
 (0)