Enables split layout by default

Summary: Enables split layout by default

Reviewed By: pentiumao

Differential Revision: D43099403

fbshipit-source-id: 9b411e90ac55aff916e35ed7cfcfb2c1c169938b

Author: adityasharat

litho-core-kotlin/src/test/kotlin/com/facebook/litho/KCachedTest.kt

@@ -27,10 +27,12 @@ import org.assertj.core.api.Assertions.assertThat
 import org.junit.Before
 import org.junit.Test
 import org.junit.runner.RunWith
+import org.robolectric.annotation.LooperMode
 
 /** Unit tests for [useCached]. */
 @Suppress("MagicNumber")
 @RunWith(LithoTestRunner::class)
+@LooperMode(LooperMode.Mode.LEGACY)
 class KCachedTest {
 
   private lateinit var context: ComponentContext

litho-core/src/main/java/com/facebook/litho/BUCK

@@ -10,7 +10,6 @@ load(
     "LITHO_ANDROIDSUPPORT_TARGET",
     "LITHO_ANNOTATIONS_TARGET",
     "LITHO_CONFIG_TARGET",
-    "LITHO_DEBUG_UTILS",
     "LITHO_INFERANNOTATIONS_TARGET",
     "LITHO_JSR_TARGET",
     "LITHO_PERFBOOST_TARGET",
@@ -67,7 +66,6 @@ litho_android_library(
         LITHO_STATS_TARGET,
         LITHO_VIEWCOMPAT_TARGET,
         LITHO_YOGA_FACTORY_TARGET,
-        LITHO_DEBUG_UTILS,
     ],
     exported_deps = [
         LITHO_ANNOTATIONS_TARGET,

litho-core/src/main/java/com/facebook/litho/ComponentTree.java

@@ -37,10 +37,12 @@
 import static com.facebook.litho.ThreadUtils.assertMainThread;
 import static com.facebook.litho.ThreadUtils.isMainThread;
 import static com.facebook.litho.config.ComponentsConfiguration.DEFAULT_BACKGROUND_THREAD_PRIORITY;
-import static com.facebook.litho.debugutils.LayoutCalculationDebugUtilsKt.flash;
 import static com.facebook.rendercore.instrumentation.HandlerInstrumenter.instrumentHandler;
 
 import android.content.Context;
+import android.graphics.Color;
+import android.graphics.drawable.Drawable;
+import android.graphics.drawable.PaintDrawable;
 import android.os.Handler;
 import android.os.HandlerThread;
 import android.os.Looper;
@@ -1125,7 +1127,7 @@ public boolean isReconciliationEnabled() {
     return mLithoConfiguration.isReconciliationEnabled;
   }
 
-  synchronized @Nullable Component getRoot() {
+  public synchronized @Nullable Component getRoot() {
     return mRoot;
   }
 
@@ -1180,6 +1182,19 @@ private void preAllocateMountContent(boolean shouldPreallocatePerMountSpec) {
     }
   }
 
+  public void setRootSync(@Nullable Component root) {
+    setRootAndSizeSpecAndWrapper(
+        root,
+        SIZE_UNINITIALIZED,
+        SIZE_UNINITIALIZED,
+        false /* isAsync */,
+        null /* output */,
+        CalculateLayoutSource.SET_ROOT_SYNC,
+        INVALID_LAYOUT_VERSION,
+        null,
+        null);
+  }
+
   public void setRootAsync(@Nullable Component root) {
     setRootAndSizeSpecAndWrapper(
         root,
@@ -2980,6 +2995,21 @@ EventHandlersController getEventHandlersController() {
     return mTreeState.getEventHandlersController();
   }
 
+  private static void flash(View view) {
+    Drawable d = new PaintDrawable(Color.RED);
+    d.setAlpha(128);
+    view.post(
+        () -> {
+          d.setBounds(0, 0, view.getWidth(), view.getHeight());
+          view.getOverlay().add(d);
+          view.postDelayed(
+              () -> {
+                view.getOverlay().remove(d);
+              },
+              500);
+        });
+  }
+
   class LayoutStateFuture extends TreeFuture<LayoutState> {
     private final Object loggerMutex = new Object();
     private final ComponentContext context;

litho-core/src/main/java/com/facebook/litho/config/ComponentsConfiguration.java

@@ -219,7 +219,7 @@ public static boolean isRenderInfoDebuggingEnabled() {
    * LithoResolutionResult, which will allow subsequent layouts to reuse that result to produce a
    * LayoutState.
    */
-  public static boolean isResolveAndLayoutFuturesSplitEnabled = false;
+  public static boolean isResolveAndLayoutFuturesSplitEnabled = true;
 
   /**
    * When enabled, and coupled with isResolveAndLayoutFuturesSplitEnabled being enabled, split
@@ -241,7 +241,7 @@ public static boolean isSplitResolveAndLayoutWithSplitHandlers() {
     return isResolveAndLayoutFuturesSplitEnabled && useSeparateThreadHandlersForResolveAndLayout;
   }
 
-  public static boolean reuseLastMeasuredNodeInComponentMeasure = false;
+  public static boolean reuseLastMeasuredNodeInComponentMeasure = true;
 
   public static boolean shouldCompareCommonPropsInIsEquivalentTo = false;
 

litho-core/src/main/java/com/facebook/litho/debugutils/BUCK

@@ -804,6 +804,11 @@ public void testSyncRenderContinuesAsyncOnMainThread() {
       return;
     }
 
+    // This isn't written to run without early interruption
+    if (!ComponentsConfiguration.isInterruptEarlyWithSplitFuturesEnabled) {
+      return;
+    }
+
     final ComponentContext c = mLegacyLithoViewRule.context;
 
     final RenderAndMeasureCounter counter = new RenderAndMeasureCounter();

litho-core/src/main/java/com/facebook/litho/debugutils/LayoutCalculationDebugUtils.kt

@@ -24,7 +24,9 @@ import com.facebook.litho.Component
 import com.facebook.litho.ComponentContext
 import com.facebook.litho.ComponentTree
 import com.facebook.litho.LithoView
+import com.facebook.litho.config.ComponentsConfiguration
 import com.facebook.litho.testing.BaseThreadLooperController
+import com.facebook.litho.testing.ResolveAndLayoutThreadLooperController
 import com.facebook.litho.testing.ThreadLooperController
 import org.junit.rules.TestRule
 import org.junit.runner.Description
@@ -41,6 +43,7 @@ class LithoRule : TestRule, TestNodeSelectionProvider {
   override fun apply(statement: Statement, description: Description): Statement =
       object : Statement() {
         override fun evaluate() {
+          ensureThreadLooperType()
           try {
             componentContext = ComponentContext(getApplicationContext<Context>())
             threadLooperController.init()
@@ -95,6 +98,16 @@ class LithoRule : TestRule, TestNodeSelectionProvider {
     shadowOf(Looper.getMainLooper()).idle()
   }
 
+  private fun ensureThreadLooperType() {
+    if (ComponentsConfiguration.isSplitResolveAndLayoutWithSplitHandlers() &&
+        threadLooperController is ThreadLooperController) {
+      threadLooperController = ResolveAndLayoutThreadLooperController()
+    } else if (!ComponentsConfiguration.isSplitResolveAndLayoutWithSplitHandlers() &&
+        threadLooperController is ResolveAndLayoutThreadLooperController) {
+      threadLooperController = ThreadLooperController()
+    }
+  }
+
   companion object {
     private val DEFAULT_WIDTH_SPEC: Int =
         View.MeasureSpec.makeMeasureSpec(1080, View.MeasureSpec.EXACTLY)

litho-it/src/test/java/com/facebook/litho/SplitFuturesTest.java

@@ -21,27 +21,17 @@
 
 public class SplitBuildAndLayoutTestRunConfiguration implements LithoTestRunConfiguration {
 
-  private final boolean defaultReuseLastMeasuredNodeInComponentMeasure =
-      ComponentsConfiguration.reuseLastMeasuredNodeInComponentMeasure;
-  private final boolean defaultIsSplitFuturesEnabled =
-      ComponentsConfiguration.isResolveAndLayoutFuturesSplitEnabled;
   private final boolean defaultIsInterruptEarlyEnabled =
       ComponentsConfiguration.isInterruptEarlyWithSplitFuturesEnabled;
 
   @Override
   public void beforeTest(FrameworkMethod method) {
-    ComponentsConfiguration.reuseLastMeasuredNodeInComponentMeasure =
-        !defaultReuseLastMeasuredNodeInComponentMeasure;
-    ComponentsConfiguration.isResolveAndLayoutFuturesSplitEnabled = !defaultIsSplitFuturesEnabled;
     ComponentsConfiguration.isInterruptEarlyWithSplitFuturesEnabled =
         !defaultIsInterruptEarlyEnabled;
   }
 
   @Override
   public void afterTest(FrameworkMethod method) {
-    ComponentsConfiguration.reuseLastMeasuredNodeInComponentMeasure =
-        defaultReuseLastMeasuredNodeInComponentMeasure;
-    ComponentsConfiguration.isResolveAndLayoutFuturesSplitEnabled = defaultIsSplitFuturesEnabled;
     ComponentsConfiguration.isInterruptEarlyWithSplitFuturesEnabled =
         defaultIsInterruptEarlyEnabled;
   }

litho-testing/src/main/java/com/facebook/litho/testing/api/LithoRule.kt

@@ -35,8 +35,10 @@ import org.assertj.core.api.Assertions
 import org.junit.Rule
 import org.junit.Test
 import org.junit.runner.RunWith
+import org.robolectric.annotation.LooperMode
 
 @RunWith(LithoTestRunner::class)
+@LooperMode(LooperMode.Mode.LEGACY)
 class DebugLogTest : RunWithDebugInfoTest() {
 
   @get:Rule val rule: LithoRule = LithoRule()

litho-testing/src/main/java/com/facebook/litho/testing/testrunner/SplitBuildAndLayoutTestRunConfiguration.java

@@ -33,12 +33,14 @@ import com.facebook.litho.widget.collection.LazyList
 import org.junit.Rule
 import org.junit.Test
 import org.junit.runner.RunWith
+import org.robolectric.annotation.LooperMode
 
 /**
  * The goal of this set of tests is just to be a health check that basic scenarios of the nodes
  * resolution and verification are working.
  */
 @RunWith(LithoTestRunner::class)
+@LooperMode(LooperMode.Mode.LEGACY)
 class NodeResolutionWithAssertionsTest : RunWithDebugInfoTest() {
 
   @get:Rule val rule: LithoRule = LithoRule()