You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add more fine-grainted mechanism to understand if TreeFuture was cancelled by Policy
Summary:
This is a bit of a defensive approach to try to avoid the issues with the cancellation experiment.
The steps are the following:
1. Adding a flag in `TreeFuture` that marks it as "cancelled" whenever we call cancel due to our policy.
2. When we cancel the Future, it can happen that an exception is triggered. If so, we verify if it is one of the expected exceptions **and** if it was marked cancelled by us. If that is the case, we throw a specific `FutureCancelledByPolicyException` and this should be caught in the `CancellationHelper` and then a `TreeFutureResult.cancelled()` should be returned.
Reviewed By: adityasharat
Differential Revision: D44495245
fbshipit-source-id: 29d0d02d9d6433e3a58ace9e5e82d0334fa17e5a
0 commit comments