Fix a bug in StateHandler

Andrew Wang · facebook-github-bot · commit 2d3de4d661d8 · 2023-02-24T15:15:59.000-08:00
Summary: We should only mark a component as needed when it actually presents in the tree, we didn't check that before adding to the set.

Reviewed By: adityasharat

Differential Revision: D43569656

fbshipit-source-id: cead38541af803f7ce7c714764c37fe2e9f93a4c
diff --git a/litho-core/src/main/java/com/facebook/litho/StateHandler.java b/litho-core/src/main/java/com/facebook/litho/StateHandler.java
@@ -266,7 +266,6 @@ synchronized void applyStateUpdatesEarly(
           }
 
           final StateContainer newStateContainer = stateContainer.clone();
-          mNeededStateContainers.add(key);
           mStateContainers.put(key, newStateContainer);
           applyStateUpdates(key, newStateContainer);
         } catch (Exception ex) {

Original file line number	Diff line number	Diff line change
`@@ -266,7 +266,6 @@ synchronized void applyStateUpdatesEarly(`
`266`	`266`	`}`
`267`	`267`
`268`	`268`	`final StateContainer newStateContainer = stateContainer.clone();`
`269`		`- mNeededStateContainers.add(key);`
`270`	`269`	`mStateContainers.put(key, newStateContainer);`
`271`	`270`	`applyStateUpdates(key, newStateContainer);`
`272`	`271`	`} catch (Exception ex) {`