Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Remove Phalcon Migrations #1278

Closed
CameronHall opened this issue Mar 11, 2019 · 9 comments
Closed

[Discussion] Remove Phalcon Migrations #1278

CameronHall opened this issue Mar 11, 2019 · 9 comments
Milestone

Comments

@CameronHall
Copy link
Contributor

I propose that we remove the Phalcon Migrations feature in the 4.0 revision of the Phalcon Developer Tools, in favor of CakePHP's Phinx.

It seems there are regular issues with the Migrations component, with 21.3% of the issues for this project related to the migrations tool alone. It makes sense, for us to offload this maintenance debt to Phinx as it is already production ready, battle tested and incredibly popular with 7M+ Downloads.

If necessary, we could compromise and create a wrapper for Phinx to maintain the functionality but offload the nitty gritty.

@Jeckerson
Copy link
Member

Agree!

@ruudboon
Copy link
Member

Agree. I would love to see the wrapper to handle the config parsing etc.

@Ultimater
Copy link
Member

Wrapper sounds like fun.

@sergeyklay
Copy link
Contributor

sergeyklay commented Mar 12, 2019

I'm ok with this. I think this may be implemented in the v4.0.x . But note we'll need to update the docs to refer to previous dev-tools version when mentioning previous implementation of migrations. We must also provide at least minimal documentation for the new implementation. And finally, what do you think guys about a migration converter or a solution (at least a tip) to use old migrations with the new version.

@sergeyklay sergeyklay added this to the 4.0.0 milestone Mar 12, 2019
@Jeckerson
Copy link
Member

@sergeyklay All what you mentioned is possible.

@CameronHall
Copy link
Contributor Author

CameronHall commented Mar 12, 2019

@sergeyklay this suggestion is only for v4.0.x. I suggest it now, as there is already a mass of backward incompatibilities between Phalcon 3 and 4, it's an appropriate time (at least I believe it to be) to also introduce backward incompatibilities to the developer tools as well.

I still think we should fix any "bugs" for the current revision. But no further work on NFRs.

@CameronHall CameronHall unpinned this issue Mar 16, 2019
@Jeckerson
Copy link
Member

Another option is doctrine migrations - https://github.com/doctrine/migrations

@CameronHall CameronHall changed the title [Discussion] Remove Phalcon Migrations Remove Phalcon Migrations Jun 24, 2019
@ruudboon
Copy link
Member

Related #1315

@ruudboon ruudboon mentioned this issue Oct 7, 2019
11 tasks
@Jeckerson Jeckerson changed the title Remove Phalcon Migrations [Discussion] Remove Phalcon Migrations Oct 19, 2019
@Jeckerson
Copy link
Member

Closing in favor - #1339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants