Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more compiler warnings when compiling single file with -Wall #825

Merged
merged 11 commits into from Jul 11, 2013
Merged

Fix more compiler warnings when compiling single file with -Wall #825

merged 11 commits into from Jul 11, 2013

Conversation

ghost
Copy link

@ghost ghost commented Jul 11, 2013

Fixes:

  • ‘phalcon_less_equal_long’ declared ‘static’ but never defined — implemented the function
  • ‘phalcon_try_execute’ declared ‘static’ but never defined — commented out the definition
  • ‘phalcon_restore_symbol_table’ declared ‘static’ but never defined — commented out the definition
  • 'phalcon_call_user_function_ex', 'phalcon_call_function', 'phalcon_lookup_class_ex' and 'phalcon_lookup_class' declared ‘static’ but never defined — implementation is provided only for PHP <= 5.3.9, therefore I moved their definitions under #if PHP_VERSION_ID <= 50309
  • 'phalcon_alt_call_user_method_ex' declared 'static' but never defined — commented out their definitions.

phalcon pushed a commit that referenced this pull request Jul 11, 2013
Fix more compiler warnings when compiling single file with -Wall
@phalcon phalcon merged commit a91d975 into phalcon:1.2.1 Jul 11, 2013
@ghost ghost deleted the compiler-warnings branch July 11, 2013 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants