Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR] Implement method \Phalcon\Forms\Element::setMessage() #576

Closed
iforp opened this issue Apr 25, 2013 · 4 comments
Closed

[NFR] Implement method \Phalcon\Forms\Element::setMessage() #576

iforp opened this issue Apr 25, 2013 · 4 comments
Labels
new feature request Planned Feature or New Feature Request
Milestone

Comments

@iforp
Copy link
Contributor

iforp commented Apr 25, 2013

It would be very useful methods:
\Phalcon\Forms\Element::setMessage(string $message)
and
\Phalcon\Forms\Form::setMessage(string $elementName, string $message)

@iforp
Copy link
Contributor Author

iforp commented Apr 25, 2013

Or may be this method should be named appendMessage

@nikolasha
Copy link

+1
Error messages should be attached to the form elements, not the form itself:
#542 (comment)

The current implementation is not logical and has an artificial restriction:
https://github.com/phalcon/cphalcon/blob/1.1.0/ext/forms/element.c#L662

Form should refer to the elements to get the error messages, but not vice versa.

@roman-kulish
Copy link

👍

@phalcon
Copy link
Collaborator

phalcon commented Jun 8, 2013

This is implemented in 1.2.0

@phalcon phalcon closed this as completed Jun 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature request Planned Feature or New Feature Request
Projects
None yet
Development

No branches or pull requests

3 participants