Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow to override superglobals in views #1617

Merged
merged 2 commits into from Dec 2, 2013
Merged

Do not allow to override superglobals in views #1617

merged 2 commits into from Dec 2, 2013

Conversation

ghost
Copy link

@ghost ghost commented Nov 30, 2013

  • Do not allow to override superglobals in views;
  • Use zend_hash_merge_ex() instead of manual iteration over the array and phalcon_set_symbol()
  • Get rid of the memory frame in Phalcon\Mvc\View\Engine\Php::render()
  • Make Phalcon\Mvc\View\Engine::render() return boolean
  • Optimize Phalcon\Mvc\View\Engine\Volt::length()
  • Optimize Phalcon\Mvc\View\Engine\Volt::isIncluded()

phalcon pushed a commit that referenced this pull request Dec 2, 2013
Do not allow to override superglobals in views
@phalcon phalcon merged commit 908d03f into phalcon:1.3.0 Dec 2, 2013
@ghost ghost deleted the view-superglobals branch December 2, 2013 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants