Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFR]: Using init() on session bag should store data in session #15494

Closed
wurst-hans opened this issue May 16, 2021 · 1 comment · Fixed by #15706
Closed

[NFR]: Using init() on session bag should store data in session #15494

wurst-hans opened this issue May 16, 2021 · 1 comment · Fixed by #15706
Assignees
@niden
Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details new feature request Planned Feature or New Feature Request

Comments

@wurst-hans
Copy link

The init() method for session bag should persist the array data in session, too. Currently, this true only for setting a new value via set() (see here).
@wurst-hans wurst-hans added the new feature request Planned Feature or New Feature Request label May 16, 2021
@Jeckerson Jeckerson added 6.0 The issues we want to solve in the 6.0 release transfer labels Sep 9, 2021
@niden niden added 5.0 The issues we want to solve in the 5.0 release and removed 6.0 The issues we want to solve in the 6.0 release transfer labels Oct 1, 2021
@niden niden mentioned this issue Oct 2, 2021
Merged
5 tasks
@niden niden linked a pull request Oct 2, 2021 that will close this issue
T15494 sessionbag init #15706
Merged
5 tasks
@niden niden added the breaks bc Functionality that breaks Backwards Compatibility label Oct 2, 2021
@niden niden self-assigned this Oct 2, 2021
@Jeckerson Jeckerson added the hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details label Oct 3, 2021
@niden
Copy link
Member

niden commented Oct 3, 2021

Resolved in #15706

Thanks @wurst-hans

@niden niden closed this as completed Oct 3, 2021
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details new feature request Planned Feature or New Feature Request
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

T15494 sessionbag init
3 participants
@niden @Jeckerson @wurst-hans