[BUG]: Null cannot be set in the source parameter when firing an event.

[fagai]

Describe the bug

Null cannot be set in the source parameter when firing an event.
There is an example using null in the documentation.
https://docs.phalcon.io/4.0/ja-jp/events#responses

Also, you cannot specify a character string.
There are many examples of using $this in the documentation, but I put values ​​such as user_id.

c4cf1db

To Reproduce

Phalcon\Events\Exception: The source of register event must be an object, got NULL"
Phalcon\Events\Exception: The source of register event must be an object, got string

Steps to reproduce the behavior:

$eventsManager->fire('custom:custom', null);

Provide minimal script to reproduce the issue

<?php

use Phalcon\Events\Manager as EventsManager;

$eventsManager = new EventsManager();

$eventsManager->attach(
    'custom:custom',
    function () {
        return 'first response';
    }
);

$eventsManager->fire('custom:custom', null);

Expected behavior
A clear and concise description of what you expected to happen.

No Error

Details

• Phalcon version: 4.0.5
• PHP Version: 7.2.30
• Operating System: alpine linux
• Installation type: Compiling from source
• Zephir version (if any):
• Server: Apache+php-fpm
• Other related info (Database, table schema):

[fagai]

@zsilbi This issue worked in 3.4.

[Izopi4a]

i don't think this would have workerd in any 3.x version. Based on this : https://github.com/phalcon/cphalcon/blob/3.0.x/phalcon/events/manager.zep#L376 2nd parameter is always the component that is listening for the event.
the 3rd param ( data ) can be null. Seems like the docs are wrong and needs to be updated

[fagai]

In the service I was developing, I have confirmed that it worked without problems even if the second argument was null. (v3.4.5)

I think the problem occurred because the following judgment was added.
https://github.com/phalcon/cphalcon/blob/4.0.x/phalcon/Events/Event.zep#L72-L76

[Izopi4a]

ok indeed in 3.4.x is working. for me it is

Version | 3.4.4 //phalcon
Powered by Zephir | Version 0.10.16-6826149172

but i think this issue is because of zephir-lang/zephir#1656. This was merged in zephir 0.11+ and we used zephir 0.10 to build phalcon 3.4.X because it was breaking everything. before that zephir wasn't respecting params and return types correctly.

for me we only need to update the docs, I don't think there is a bug here.

also I am able to reproduce this error:

 [TypeError] Phalcon\Events\Manager::fire(): Argument #2 ($source) must be of type object, null given

and not exactly what you have shown. but I am pretty sure it is the same case.

[fagai]

I see.

I had this problem because I sometimes didn't use the second argument.
Currently, we are dealing with it by passing an empty object. So if it's in the right direction, that's fine.

[Jeckerson]

I'm starting to see some sense to 2nd argument source be nullable:

object source = null

@niden Could you provide more information if my thoughts makes sense?

[niden]

I looked at the manager code and making the source nullable can be done. The manager can fire the event when the source is null

let status = call_user_func_array(
    handler,
    [event, source, data]
);

We can make this change in v5 since it will break BC.

[niden]

Personally I never had to send null to the source; I always sent the actual object that was using this code.

[niden]

Resolved in #15710

Thank you @fagai