Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive output logging results in unresponsive Web UI #3750

Closed
oliversalzburg opened this issue Feb 25, 2025 · 3 comments
Closed

Excessive output logging results in unresponsive Web UI #3750

oliversalzburg opened this issue Feb 25, 2025 · 3 comments

Comments

@oliversalzburg
Copy link

I know I'm dealing with an edge case. I'm happy to accept that this does not require a solution in the action. I'm giving it a shot regardless :)

I'm dealing with a repository that contains beyond 1 million files, with thousands of changes per PR.. When the action tries to create the pull request, the git wrapper will list every file in the change in the process, sometimes causing over 100 MB of log output.

This is a performance issue for the PR creation itself, as it takes several minutes, and the job log becomes unusable, sometimes the UI has a hard time responding.

It would be nice to have some control over log verbosity in the action. But maybe it would also be a good idea to review logging in general. For example, calls like

const output = await this.exec([
'-c',
'core.quotePath=false',
'show',
'--raw',
'--cc',
'--no-renames',
'--no-abbrev',
`--format=%H%n%T%n%P%n%G?%n%s%n%b%n${endOfBody}`,
ref
])
might not really have to be piped through to stdout, if you really only want to parse the information internally.

@peter-evans
Copy link
Owner

Hi @oliversalzburg

Thanks for reporting this. You're right, I think it's too verbose at the moment. I'll see what changes can be made to address this.

@peter-evans
Copy link
Owner

I've released a change as v7.0.8 / v7, which suppresses the output of two git operations which were very verbose. I'm not sure if this goes far enough yet for your particular case, but please try the new version and let me know if it's better.

@oliversalzburg
Copy link
Author

I had already migrated that specific project to a custom solution to serve additional needs. So I can't easily verify the difference any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants