Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCM] Users can invite themselves to their own federated connection #12183

Open
2403905 opened this issue Feb 14, 2025 · 3 comments
Open

[OCM] Users can invite themselves to their own federated connection #12183

2403905 opened this issue Feb 14, 2025 · 3 comments
Assignees
Labels
Type:Bug Something isn't working

Comments

@2403905
Copy link
Contributor

2403905 commented Feb 14, 2025

Describe the bug

When a user generates a token for federated connection and pastes it to their own accept invitation field, then a federated connection is created with the user itself.

Related issue owncloud/ocis#11004

Image

Expected behavior

Deny to accept the federated connection from the same instance.

Actual behavior

A clear and concise description of what happened.

Setup

Please describe how you started the server and provide a list of relevant environment variables or configuration files.

OCIS_XXX=somevalue
OCIS_YYY=somevalue
PROXY_XXX=somevalue

Additional context

Add any other context about the problem here.

@2403905 2403905 added the Type:Bug Something isn't working label Feb 14, 2025
@mzner mzner self-assigned this Mar 13, 2025
@mzner
Copy link
Contributor

mzner commented Mar 13, 2025

@2403905 I'm not able to reproduce this bug any more. Is this still relevant or should we close the ticket?

@LukasHirt fyi

@LukasHirt
Copy link
Collaborator

Can confirm that I am now receiving correct response in this case:

{
    "code": "INVALID_PARAMETER",
    "message": "can not accept an invite from the same instance"
}

Versions:

Infinite Scale 7.1.0+c2736dfb47 Community
ownCloud Web UI 11.3.0

@2403905
Copy link
Contributor Author

2403905 commented Mar 14, 2025

It was fixed on the backend. But I think we should have some validation on web and disallow pressing the Accept invitation button.

@LukasHirt LukasHirt moved this from Qualification to Prio 2 in Infinite Scale Team Board Mar 14, 2025
@LukasHirt LukasHirt moved this from Prio 2 to Prio 3 or less in Infinite Scale Team Board Mar 14, 2025
@LukasHirt LukasHirt moved this from Prio 3 or less to In progress in Infinite Scale Team Board Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
Status: In progress
Development

No branches or pull requests

3 participants