feat: add distroless #1348
Merged
feat: add distroless #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
reviewed
Jun 26, 2023
|
|
||
| RUN apk --no-cache --latest upgrade &&\ | ||
| apk --no-cache --upgrade --latest add ca-certificates | ||
| FROM gcr.io/distroless/base-nossl-debian11:nonroot AS runner |
There was a problem hiding this comment.
Does this come with CGO? We need it for SQLite
There was a problem hiding this comment.
Yes, the image comes with glibc -> https://github.com/GoogleContainerTools/distroless/blob/main/base/README.md :)
hperl
approved these changes
Jun 29, 2023
| @@ -0,0 +1,8 @@ | |||
| FROM gcr.io/distroless/static-debian11:nonroot | |||
|
|
|||
| COPY keto /usr/bin/keto | |||
There was a problem hiding this comment.
What is this image being used for? How will the keto binary be built? In this case it needs to be for linux-x86 with CGO=0. Will this be guaranteed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments