refactor(config): refactor the config system #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge the base
…t into the `CliArgs` struct to improve the code
…k_help` to `true`
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
- Coverage 80.85% 78.43% -2.41%
==========================================
Files 14 14
Lines 595 598 +3
==========================================
- Hits 481 469 -12
- Misses 114 129 +15
☔ View full report in Codecov by Sentry. |
0x61nas
changed the title
update_args function from the Config struct into the CliArgsConfig struct the main setings container
…it dosn't exisits
0x61nas
changed the title
Config struct the main setings containerConfig struct the main settings container and auto-create the config file if it doesn't exist
…it dosn't exisits
…to refactor-configs-code
…forks/halp into refactor-configs-code
…forks/halp into refactor-configs-code
…it dosn't exisits
…to refactor-configs-code
…e default config file
|
I messed up the commit history a little bit in my attempt to fix the typo in 2f2ccc0 commit message, sorry about that |
orhun
reviewed
Jul 4, 2023
orhun
reviewed
Jul 4, 2023
orhun
reviewed
Jul 4, 2023
orhun
changed the title
|
Hey @0x61nas I just realized |
|
Oh, I didn't notice that. I'll fix this issue quickly as I can |
This was referenced Jul 12, 2023
Closed
bors bot
added a commit
that referenced
this pull request
Jul 17, 2023
81: fix(cli): fix the check option r=orhun a=0x61nas <!--- Thank you for contributing to halp! 🐙 --> ## Description Add the missing code to override the check args in the config instance with the `--check` CLI option ## Motivation and Context - Fix the issue that's introduced in #62 ## How Has This Been Tested? - I trayed to pass `--check="-h"` and it worked as expected - I trayed to pass ` --check='-h' --check='-V'` and it worked as expected also ## Types of Changes - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation (no code change) - [ ] Refactor (refactoring production code) - [ ] Other <!--- (provide information) --> ## Checklist: - [x] My code follows the code style of this project. - [x] I have updated the documentation accordingly. - [x] I have formatted the code with [rustfmt](https://github.com/rust-lang/rustfmt). - [x] I checked the lints with [clippy](https://github.com/rust-lang/rust-clippy). - [x] I have added tests to cover my changes. - [x] All new and existing tests passed. > This's an alternative to #79 Co-authored-by: Anas Elgarhy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the
Configthe main settings container instead ofCliArgs. and auto-create the config file in~/.confg/halp/config.tomlif it doesn't exist, and give the command-line arguments priority over the config fileMotivation and Context
update_argsfunction from theConfigstruct into theCliArgs#61Fix: no help flag doesn't work when I have set thecheck_helpvalue to true in the config file #63check_versionvalue to true in the config file #64How Has This Been Tested?
cargo t --lib, all the tests are passedcargo r -- --helpandcargo r -- plz --help, it gives me the expected output--no-versionand--no-helpflagsTypes of Changes
Checklist: