Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(config): update comments for all configuration options #1057

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Cyclonit
Copy link
Contributor

Description

Updated the comments in all instances of config.toml and config.rs.

Motivation and Context

Some of the comments were unclear, had inconsistent punctation or wording.

How Has This Been Tested?

no functional changes

Screenshots / Logs (if applicable)

does not apply

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Cyclonit Cyclonit requested a review from orhun as a code owner February 25, 2025 13:18
@Cyclonit Cyclonit force-pushed the feature/update_config_comments branch from 96ef88f to cdddd9d Compare February 25, 2025 14:10
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.85%. Comparing base (cd26bb2) to head (d10937c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1057      +/-   ##
==========================================
- Coverage   41.90%   41.85%   -0.05%     
==========================================
  Files          21       21              
  Lines        1790     1790              
==========================================
- Hits          750      749       -1     
- Misses       1040     1041       +1     
Flag Coverage Δ
unit-tests 41.85% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cyclonit Cyclonit force-pushed the feature/update_config_comments branch from cdddd9d to a0ae4cd Compare February 25, 2025 14:19
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great cleanup! 🎉

I had some comments, it would be nice to update the other occurrences based on those as well :)

ignore_tags = ""
# sort the tags topologically
# Order releases topologically instead of chronologically.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Order releases topologically instead of chronologically.
# Order tags topologically instead of chronologically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why tags instead of releases? Doesn't it affect the release order? The description should reflect the options effect and not how it is implemented.

Copy link
Owner

@orhun orhun Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using this flag to sort the tags, which then affects the order of the releases.

if !topo_order {
tags.sort_by(|a, b| a.0.time().seconds().cmp(&b.0.time().seconds()));
}

So I think using "tags" would be more correct here.

The description should reflect the options effect and not how it is implemented.

I think the user should be aware of tags vs releases when using a git automation tool like this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But a user wants to know how the config affects the final result. And there it affects the order of releases, by sorting the tags. The variable tags in your code reference could more accurately be referred to as release_tags. Because those tags represent releases. I am willing to be overruled, but these are my last two cents ;)

Comment on lines 86 to 87
# How to order commits in each group/release within the changelog.
# allowed values: newest, oldest
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# How to order commits in each group/release within the changelog.
# allowed values: newest, oldest
# Whether to order commits in each group/release by newest/oldest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked with others and they agreed that putting the options on a separate line makes them being the valid options easier to understand. What reason is there to keep in short?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a big deal imo - I just didn't want to spend a whole line for explaining possible values for this option.

If we go with a new line, this might imply that we are following this format for the other options in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that not be a good idea?

@Cyclonit Cyclonit force-pushed the feature/update_config_comments branch from a0ae4cd to d10937c Compare February 26, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants