Request a convenient way to see review comments together with the resulting code changes #152465
Replies: 1 comment
-
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
-
Select Topic Area
Product Feedback
Body
I request the ability to conveniently and simultaneously view unresolved review comments and the code changes that were made since that review.
It appears that GitHub currently cannot simultaneously show these in a single view, see https://github.com/orgs/community/discussions/152334. I can see the review comments in the context of the old code changes that they apply to (e.g., in the "Conversation" view) but then the new code changes that were made to resolve the review comments aren't simultaneously visible. Or I can see the new code changes (e.g., in the "Files changed" view configured to show the changes since the last review) but then the review comments that prompted those changes aren't visible.
I can work around this problem by arranging two separate browser windows side by side, one to show the old review comments and one to show the new code changes, but then I need a very wide screen and I have to do the work figuring out which new code change is associated with which old review comment. The latter is tedious and an excellent candidate for automation.
This means that the process of reviewing code changes isn't as convenient as it could be. To complete a code review I need to inspect the new code changes, check that they resolve the old review comments, and then mark those old review comments as resolved. This would be most conveniently done in a view that simultaneously showed the review comments, the old code changes that they applied to, and the new code changes that were made after those review comments.
One way in which it could be done is to display a three-way comparison, as is common for resolving merge conflicts. The "A" version could be the base commit of the previous review (or the oldest commit that has unresolved review comments associated with it). The "B" version could be the last commit included in the previous review, which is equal to the base commit of the latest changes. And the "C" version could be the most recent commit. The "A" and "B" versions could have the (unresolved) review comments in them, as in the "Conversations" view. This, too, requires a wide screen, but not nearly as wide as having two separate browser windows as required by the current workaround.
Beta Was this translation helpful? Give feedback.
All reactions