Bug/53451 always show ckeditor tool bar on screen when scrolling #18083
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dombesz
approved these changes
Feb 26, 2025
This was not working due to the overflow attribute being set to something else than visible or clip. As `clip` is mostly the same as `hidden`, I was able to restore the stickiness by using that. See https://benfrain.com/yes-you-can-use-position-sticky-and-overflow-together/
EinLama
force-pushed
the
bug/53451-always-show-ckeditor-tool-bar-on-screen-when-scrolling
branch
from
dee71d7 to
d0357ef
Compare
…reen-when-scrolling
EinLama
force-pushed
the
bug/53451-always-show-ckeditor-tool-bar-on-screen-when-scrolling
branch
from
485e0a6 to
152282f
Compare
|
Reran the CI a couple of times. All the remaining red specs are flaky ones that have no cause in this PR, so I'll merge. |
EinLama
deleted the
bug/53451-always-show-ckeditor-tool-bar-on-screen-when-scrolling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/53451
What are you trying to accomplish?
When you shrink your browser window (aka you are in "moblie mode"), the editor toolbar should stick to the top of the scroll container when you edit a work package description.
Screenshots
What approach did you choose and why?
TIL that when any parent of a sticky-element has an overflow that is set to
auto,hiddenorscroll, the stickiness does not take effect. There seem to be further issues with parents defining a set height, etc.In our case, the stickiness could be restored by using
overflow: clipinstead ofoverflow: hidden. Clip does the same as hidden, but does not open up a new formatting context, preserving the functionality ofsticky.https://benfrain.com/yes-you-can-use-position-sticky-and-overflow-together/
Merge checklist