Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improvements in package caching #1274

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

a-gave
Copy link
Contributor

@a-gave a-gave commented Feb 25, 2025

This adds some squid directives to consider fresh longer kernel modules of already compiled releases, to prevent revalidation against the origin server which consumes time.

An automatic mechanism to refresh the below squid directive should be included (e.g., 24h after the first appearance on https://downloads.openwrt.org/.versions.json)

refresh_pattern ^http://downloads.openwrt.org/releases/.*(23.05.[6-99]|24.10.[1-99]|25.*|SNAPSHOT)/targets/.* 0 100% 0 refresh-ims

This adds also a fallback to no_proxy (https) in case STDERR contains “package index are corrupt” to rule out cache problems and to allow packages to be considered fresh longer and thus not revalidated against the origin server

@a-gave a-gave force-pushed the feat/improve_package_caching branch from 505be82 to 84ffb51 Compare February 25, 2025 16:31
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.29%. Comparing base (5e65dec) to head (dc53a56).
Report is 225 commits behind head on main.

Files with missing lines Patch % Lines
asu/build.py 25.00% 6 Missing ⚠️
asu/util.py 69.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1274      +/-   ##
==========================================
+ Coverage   80.75%   90.29%   +9.53%     
==========================================
  Files          15       13       -2     
  Lines         977     1205     +228     
==========================================
+ Hits          789     1088     +299     
+ Misses        188      117      -71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-gave a-gave force-pushed the feat/improve_package_caching branch from 1ab8034 to 2a44ded Compare February 26, 2025 09:55
@a-gave a-gave changed the title draft: feat: improvements in package caching feat: improvements in package caching Feb 26, 2025
@a-gave a-gave marked this pull request as draft February 26, 2025 10:43
@a-gave a-gave force-pushed the feat/improve_package_caching branch from 2a44ded to 3670a3d Compare February 26, 2025 23:26
@a-gave a-gave force-pushed the feat/improve_package_caching branch from 3670a3d to dc53a56 Compare February 26, 2025 23:28
@aparcar
Copy link
Member

aparcar commented Feb 27, 2025

I recon you're really limited on bandwidth? Or what is the motivation to avoid the extra checks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants