Resolve code review

- Log using Timber

- Store key names in constants

Author: kelvin-ngure

android/engine/src/main/java/org/smartregister/fhircore/engine/datastore/serializers/SerializerConstants.kt

@@ -0,0 +1,4 @@
+package org.smartregister.fhircore.engine.datastore.serializers
+
+class SerializerConstants {
+}

android/quest/src/main/java/org/smartregister/fhircore/quest/ui/appsetting/AppSettingViewModel.kt

@@ -44,8 +44,10 @@ import org.smartregister.fhircore.engine.configuration.profile.ProfileConfigurat
 import org.smartregister.fhircore.engine.configuration.register.RegisterConfiguration
 import org.smartregister.fhircore.engine.data.local.DefaultRepository
 import org.smartregister.fhircore.engine.data.remote.fhir.resource.FhirResourceDataSource
-import org.smartregister.fhircore.engine.datastore.DataStoreHelper
-import org.smartregister.fhircore.engine.datastore.DataStoresRepository
+import org.smartregister.fhircore.engine.datastore.PreferenceDataStore
+import org.smartregister.fhircore.engine.datastore.ProtoDataStore
+import org.smartregister.fhircore.engine.datastore.mockdata.SerializablePractitionerDetails
+import org.smartregister.fhircore.engine.datastore.mockdata.SerializableUserInfo
 import org.smartregister.fhircore.engine.di.NetworkModule
 import org.smartregister.fhircore.engine.domain.model.FhirResourceConfig
 import org.smartregister.fhircore.engine.domain.model.ResourceConfig
@@ -69,7 +71,8 @@ constructor(
   val fhirResourceDataSource: FhirResourceDataSource,
   val defaultRepository: DefaultRepository,
   val sharedPreferencesHelper: SharedPreferencesHelper,
-  val dataStoreHelper: DataStoreHelper,
+  val preferenceDataStore: PreferenceDataStore,
+  val protoDataStore: ProtoDataStore,
   val configService: ConfigService,
   val configurationRegistry: ConfigurationRegistry,
   val dispatcherProvider: DispatcherProvider,
@@ -222,9 +225,6 @@ constructor(
           showProgressBar.postValue(false)
           if (loadConfigSuccessful) {
             sharedPreferencesHelper.write(SharedPreferenceKey.APP_ID.name, thisAppId)
-            viewModelScope.launch { dataStoreHelper.writePreference(DataStoresRepository.Keys.APP_ID, thisAppId) }
-            val x = listOf<Int>()
-            x.forEach {  }
             context.getActivity()?.launchActivityWithNoBackStackHistory<LoginActivity>()
           } else {
             _error.postValue(context.getString(R.string.application_not_supported, thisAppId))

android/quest/src/main/java/org/smartregister/fhircore/quest/ui/login/LoginActivity.kt

@@ -28,6 +28,7 @@ import androidx.work.WorkManager
 import dagger.hilt.android.AndroidEntryPoint
 import javax.inject.Inject
 import org.smartregister.fhircore.engine.data.remote.shared.TokenAuthenticator
+import org.smartregister.fhircore.engine.datastore.ProtoDataStore
 import org.smartregister.fhircore.engine.p2p.dao.P2PReceiverTransferDao
 import org.smartregister.fhircore.engine.p2p.dao.P2PSenderTransferDao
 import org.smartregister.fhircore.engine.sync.AppSyncWorker