Skip to content

Commit dd998c1

Browse files
committed
Resolve code review
- Log using Timber - Store key names in constants
1 parent f9c03d2 commit dd998c1

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
package org.smartregister.fhircore.engine.datastore.serializers
2+
3+
class SerializerConstants {
4+
}

android/quest/src/main/java/org/smartregister/fhircore/quest/ui/appsetting/AppSettingViewModel.kt

+6-6
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,10 @@ import org.smartregister.fhircore.engine.configuration.profile.ProfileConfigurat
4444
import org.smartregister.fhircore.engine.configuration.register.RegisterConfiguration
4545
import org.smartregister.fhircore.engine.data.local.DefaultRepository
4646
import org.smartregister.fhircore.engine.data.remote.fhir.resource.FhirResourceDataSource
47-
import org.smartregister.fhircore.engine.datastore.DataStoreHelper
48-
import org.smartregister.fhircore.engine.datastore.DataStoresRepository
47+
import org.smartregister.fhircore.engine.datastore.PreferenceDataStore
48+
import org.smartregister.fhircore.engine.datastore.ProtoDataStore
49+
import org.smartregister.fhircore.engine.datastore.mockdata.SerializablePractitionerDetails
50+
import org.smartregister.fhircore.engine.datastore.mockdata.SerializableUserInfo
4951
import org.smartregister.fhircore.engine.di.NetworkModule
5052
import org.smartregister.fhircore.engine.domain.model.FhirResourceConfig
5153
import org.smartregister.fhircore.engine.domain.model.ResourceConfig
@@ -69,7 +71,8 @@ constructor(
6971
val fhirResourceDataSource: FhirResourceDataSource,
7072
val defaultRepository: DefaultRepository,
7173
val sharedPreferencesHelper: SharedPreferencesHelper,
72-
val dataStoreHelper: DataStoreHelper,
74+
val preferenceDataStore: PreferenceDataStore,
75+
val protoDataStore: ProtoDataStore,
7376
val configService: ConfigService,
7477
val configurationRegistry: ConfigurationRegistry,
7578
val dispatcherProvider: DispatcherProvider,
@@ -222,9 +225,6 @@ constructor(
222225
showProgressBar.postValue(false)
223226
if (loadConfigSuccessful) {
224227
sharedPreferencesHelper.write(SharedPreferenceKey.APP_ID.name, thisAppId)
225-
viewModelScope.launch { dataStoreHelper.writePreference(DataStoresRepository.Keys.APP_ID, thisAppId) }
226-
val x = listOf<Int>()
227-
x.forEach { }
228228
context.getActivity()?.launchActivityWithNoBackStackHistory<LoginActivity>()
229229
} else {
230230
_error.postValue(context.getString(R.string.application_not_supported, thisAppId))

android/quest/src/main/java/org/smartregister/fhircore/quest/ui/login/LoginActivity.kt

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import androidx.work.WorkManager
2828
import dagger.hilt.android.AndroidEntryPoint
2929
import javax.inject.Inject
3030
import org.smartregister.fhircore.engine.data.remote.shared.TokenAuthenticator
31+
import org.smartregister.fhircore.engine.datastore.ProtoDataStore
3132
import org.smartregister.fhircore.engine.p2p.dao.P2PReceiverTransferDao
3233
import org.smartregister.fhircore.engine.p2p.dao.P2PSenderTransferDao
3334
import org.smartregister.fhircore.engine.sync.AppSyncWorker

0 commit comments

Comments
 (0)