Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add install and usage doc #84

Merged
merged 1 commit into from
Jan 28, 2022
Merged

doc: add install and usage doc #84

merged 1 commit into from
Jan 28, 2022

Conversation

mulbc
Copy link
Member

@mulbc mulbc commented Jan 20, 2022

No description provided.

@mulbc
Copy link
Member Author

mulbc commented Jan 20, 2022

This should also help fix #83

@mulbc mulbc force-pushed the cblum-install-doc branch 3 times, most recently from c5b6fb3 to 6f39b83 Compare January 20, 2022 13:33
@mulbc mulbc changed the title Add install and usage doc doc: add install and usage doc Jan 20, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2022
nbalacha
nbalacha suggested changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@nbalacha nbalacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message to include a subject or combine the 2 commits into one.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2022
@mulbc mulbc force-pushed the cblum-install-doc branch from 6c9f92d to b6b9cff Compare January 27, 2022 09:31
@mulbc mulbc requested a review from nbalacha January 27, 2022 10:20
@mulbc mulbc force-pushed the cblum-install-doc branch from b6b9cff to 1b86e6f Compare January 27, 2022 12:54
nbalacha
nbalacha suggested changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@nbalacha nbalacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the changes to config/manager/kustomization.yaml and controllers/topolvm_controller.go from the PR.

@mulbc mulbc force-pushed the cblum-install-doc branch from 1b86e6f to cb8b488 Compare January 27, 2022 16:48
@mulbc
Copy link
Member Author

mulbc commented Jan 27, 2022

one git commit --all --ammend too often -.- fixed now :)

@mulbc mulbc requested a review from nbalacha January 27, 2022 16:49
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mulbc, nbalacha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nbalacha nbalacha merged commit a3b3a24 into openshift:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbalacha nbalacha nbalacha approved these changes

Assignees

@nbalacha nbalacha

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mulbc @nbalacha