OCPBUGS-23995: fix: set failed status on device check failure

[jakobmoellerdev]

Sets "Failed" status correctly if the device Resolution resulted in an error. Previously it was set to progressing. Also a failure event of type "DevicePathCheckFailed" is issued and made visible in LVMCluster

[openshift-ci-robot]

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-23995, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Sets "Failed" status correctly if the device Resolution resulted in an error. Previously it was set to progressing. Also a failure event of type "DevicePathCheckFailed" is issued and made visible in LVMCluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jakobmoellerdev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

Codecov Report

Merging #516 (542be4e) into main (cf5eeb1) will decrease coverage by 0.08%.
Report is 4 commits behind head on main.
The diff coverage is 60.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   82.17%   82.10%   -0.08%     
==========================================
  Files          24       24              
  Lines        1784     1788       +4     
==========================================
+ Hits         1466     1468       +2     
- Misses        218      219       +1     
- Partials      100      101       +1     

Files	Coverage Δ
internal/controllers/vgmanager/controller.go	76.86% <60.00%> (-0.28%)	⬇️

[suleymanakbas91]

/lgtm

[openshift-ci]

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jakobmoellerdev: Jira Issue OCPBUGS-23995: All pull requests linked via external trackers have merged:

• openshift/lvm-operator#516

Jira Issue OCPBUGS-23995 has been moved to the MODIFIED state.

In response to this:

Sets "Failed" status correctly if the device Resolution resulted in an error. Previously it was set to progressing. Also a failure event of type "DevicePathCheckFailed" is issued and made visible in LVMCluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.