OCPBUGS-11486: fix: use native leader lock implementation

[jakobmoellerdev]

Turns out that the openshift leader election Lock is not 1:1 compatible to the controller runtime lock interface even though it can be passed. This is because the Lock looses communication to the API server through a context cancel and thus is forced by controller runtime to restart. The new lock configuration this PR provides only uses the correct Lease/Retry/Skew values, but uses the native controller runtime implementation for actually setting up the Lease object and tracking it. That way the restart is prohibited.

[openshift-ci-robot]

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-11486, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Turns out that the openshift leader election Lock is not 1:1 compatible to the controller runtime lock interface even though it can be passed. This is because the Lock looses communication to the API server through a context cancel and thus is forced by controller runtime to restart. The new lock configuration this PR provides only uses the correct Lease/Retry/Skew values, but uses the native controller runtime implementation for actually setting up the Lease object and tracking it. That way the restart is prohibited.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jakobmoellerdev]

/jira refresh

[openshift-ci-robot]

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-11486, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jakobmoellerdev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[suleymanakbas91]

/lgtm

[openshift-ci]

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jakobmoellerdev: Jira Issue OCPBUGS-11486: All pull requests linked via external trackers have merged:

• openshift/lvm-operator#370
• openshift/lvm-operator#376
• openshift/lvm-operator#377
• openshift/lvm-operator#476
• openshift/lvm-operator#478

Jira Issue OCPBUGS-11486 has been moved to the MODIFIED state.

In response to this:

Turns out that the openshift leader election Lock is not 1:1 compatible to the controller runtime lock interface even though it can be passed. This is because the Lock looses communication to the API server through a context cancel and thus is forced by controller runtime to restart. The new lock configuration this PR provides only uses the correct Lease/Retry/Skew values, but uses the native controller runtime implementation for actually setting up the Lease object and tracking it. That way the restart is prohibited.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.