Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-347: chore: unify controller naming #441

Merged

Conversation

jakobmoellerdev
Copy link
Contributor

Unififes all controllers to have the same structure for their go file naming. Renames all reconcilers Reconciler and differentiates them by go convention depending on the package.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2023

@jakobmoellerdev: This pull request references OCPVE-347 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Unififes all controllers to have the same structure for their go file naming. Renames all reconcilers Reconciler and differentiates them by go convention depending on the package.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2023

@jakobmoellerdev: This pull request references OCPVE-347 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Unififes all controllers to have the same structure for their go file naming. Renames all reconcilers Reconciler and differentiates them by go convention depending on the package.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jerpeter1 and qJkee October 6, 2023 11:33
@codecov-commenter
Copy link

Codecov Report

Merging #441 (9f97b53) into main (6c37220) will not change coverage.
The diff coverage is 75.55%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #441   +/-   ##
=======================================
  Coverage   57.65%   57.65%           
=======================================
  Files          20       20           
  Lines        1547     1547           
=======================================
  Hits          892      892           
  Misses        539      539           
  Partials      116      116           
Files Coverage Δ
...ernal/controllers/lvmcluster/controller_watches.go 64.93% <100.00%> (ø)
internal/controllers/vgmanager/devices.go 80.17% <100.00%> (ø)
internal/controllers/vgmanager/wipe_devices.go 71.15% <100.00%> (ø)
internal/controllers/lvmcluster/controller.go 62.62% <86.66%> (ø)
internal/controllers/vgmanager/status.go 39.47% <71.42%> (ø)
.../controllers/persistent-volume-claim/controller.go 60.29% <25.00%> (ø)
internal/controllers/vgmanager/controller.go 34.21% <60.00%> (ø)

@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-347-naming-alignment branch 2 times, most recently from 14192c3 to 4627688 Compare October 6, 2023 13:39
@jakobmoellerdev
Copy link
Contributor Author

/test precommit-check

@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-347-naming-alignment branch from 4627688 to 9fa2e5f Compare October 6, 2023 15:02
Signed-off-by: Jakob Möller <[email protected]>
@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-347-naming-alignment branch from 9fa2e5f to ad34f71 Compare October 6, 2023 15:52
@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws

1 similar comment
@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 8, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@suleymanakbas91
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2023

@jakobmoellerdev: This pull request references OCPVE-347 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "openshift-4.15" instead.

In response to this:

Unififes all controllers to have the same structure for their go file naming. Renames all reconcilers Reconciler and differentiates them by go convention depending on the package.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2023

@jakobmoellerdev: This pull request references OCPVE-347 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "openshift-4.15" instead.

In response to this:

Unififes all controllers to have the same structure for their go file naming. Renames all reconcilers Reconciler and differentiates them by go convention depending on the package.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 4d94695 into openshift:main Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants