-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPVE-707: chore: unify build binaries and optimize dockerfile #429
OCPVE-707: chore: unify build binaries and optimize dockerfile #429
Conversation
@jakobmoellerdev: This pull request references OCPVE-707 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Skipping CI for Draft Pull Request. |
/test all |
7049edc
to
b613cab
Compare
/test all |
/test images |
/retest-required |
2 similar comments
/retest-required |
/retest-required |
@jakobmoellerdev: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev, suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This uses cobra to unify the vgmanager and lvm operator binaries under a single binary so we only have to run go build once (speeds up compile time x2), and also optimizes the dockerfile to reuse the vendor directory instead of calling
go mod download
every time, further speeding up builds by about 10-20s (depending on how long downloading takes, much faster for slower connections). Also moves all binaries undercmd
and removes top levelmain.go