Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-698: bump k8s dependencies to 1.28.1 #416

Merged

Conversation

jakobmoellerdev
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev commented Sep 11, 2023

Also includes breaking changes for Webhook Server and Metrics Server for controller runtime >0.16.x. Also removes github.com/openshift/custom-resource-status and incorporates their conditions into our API as it is no longer maintained.

Go 1.21 will be blocked until registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.21-openshift-4.15 is available and integrated into openshift-release. Thus I opted to not bump go version in this PR

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 11, 2023

@jakobmoellerdev: This pull request references OCPVE-698 which is a valid jira issue.

In response to this:

Also includes breaking changes for Webhook Server and Metrics Server for controller runtime >0.16.x. Also removes github.com/openshift/custom-resource-status and incorporates their conditions into our API as it is no longer maintained

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 11, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 11, 2023
@jakobmoellerdev
Copy link
Contributor Author

/test all

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

Merging #416 (d9f8789) into main (26bda34) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #416   +/-   ##
=======================================
  Coverage   62.41%   62.41%           
=======================================
  Files          27       27           
  Lines        2336     2336           
=======================================
  Hits         1458     1458           
  Misses        747      747           
  Partials      131      131           
Files Changed Coverage Δ
api/v1alpha1/lvmcluster_types.go 100.00% <ø> (ø)

@jakobmoellerdev jakobmoellerdev changed the title OCPVE-698: bump k8s dependencies for 0.28.1 OCPVE-698: bump go/k8s dependencies for go1.21/0.28.1 Sep 11, 2023
@jakobmoellerdev jakobmoellerdev changed the title OCPVE-698: bump go/k8s dependencies for go1.21/0.28.1 OCPVE-698: bump go/k8s dependencies for go1.21/k8s 0.28.1 Sep 11, 2023
@jakobmoellerdev
Copy link
Contributor Author

/test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 11, 2023

@jakobmoellerdev: This pull request references OCPVE-698 which is a valid jira issue.

In response to this:

Also includes breaking changes for Webhook Server and Metrics Server for controller runtime >0.16.x. Also removes github.com/openshift/custom-resource-status and incorporates their conditions into our API as it is no longer maintained.

Blocked until registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.21-openshift-4.15 is available and integrated into openshift-release. We can also omit the go update, then it will run right now.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-698-k8s-0.28.x branch 2 times, most recently from a870f3e to 4814e9f Compare September 11, 2023 11:29
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 11, 2023

@jakobmoellerdev: This pull request references OCPVE-698 which is a valid jira issue.

In response to this:

Also includes breaking changes for Webhook Server and Metrics Server for controller runtime >0.16.x. Also removes github.com/openshift/custom-resource-status and incorporates their conditions into our API as it is no longer maintained.

Go 1.21 will be blocked until registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.21-openshift-4.15 is available and integrated into openshift-release. Thus I opted to not bump go version in this PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev jakobmoellerdev changed the title OCPVE-698: bump go/k8s dependencies for go1.21/k8s 0.28.1 OCPVE-698: bump k8s dependencies to 0.28.1 Sep 11, 2023
@jakobmoellerdev
Copy link
Contributor Author

/test all

1 similar comment
@jakobmoellerdev
Copy link
Contributor Author

/test all

@jakobmoellerdev jakobmoellerdev changed the title OCPVE-698: bump k8s dependencies to 0.28.1 OCPVE-698: bump k8s dependencies to 1.28.1 Sep 11, 2023
@jakobmoellerdev
Copy link
Contributor Author

/test all

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws-sno

@jakobmoellerdev jakobmoellerdev marked this pull request as ready for review September 11, 2023 16:54
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2023
@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws-sno

@suleymanakbas91
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2023
@jakobmoellerdev
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@suleymanakbas91
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2023
@openshift-merge-robot openshift-merge-robot merged commit 04d6f01 into openshift:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants