OCPVE-667: fix: allow no default deviceClass to be set

[jakobmoellerdev]

This allows no default deviceClass to be present. Since this is a change from previous validation it now includes a warning if no default is set: "no default deviceClass was specified, it will be mandatory to specify the storage class"

TODO:

• Test case using no default deviceClass that succeeds in e2e tests

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[jakobmoellerdev]

/test all

[codecov-commenter]

Codecov Report

Merging #396 (efc5dbe) into main (a962b90) will increase coverage by 41.65%.
Report is 49 commits behind head on main.
The diff coverage is 50.54%.

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #396       +/-   ##
===========================================
+ Coverage   16.59%   58.24%   +41.65%     
===========================================
  Files          24       26        +2     
  Lines        2061     2182      +121     
===========================================
+ Hits          342     1271      +929     
+ Misses       1693      817      -876     
- Partials       26       94       +68     

Files Changed	Coverage Δ
api/v1alpha1/lvmcluster_webhook.go	0.00% <0.00%> (ø)
controllers/lvmcluster_controller_watches.go	90.00% <ø> (+90.00%)	⬆️
pkg/vgmanager/lvm.go	52.03% <ø> (+4.06%)	⬆️
controllers/scc.go	10.41% <25.00%> (+10.41%)	⬆️
pkg/vgmanager/vgmanager_controller.go	11.76% <28.07%> (+11.76%)	⬆️
controllers/topolvm_node.go	93.05% <33.33%> (+93.05%)	⬆️
controllers/utils.go	45.09% <34.61%> (+5.09%)	⬆️
controllers/topolvm_snapshotclass.go	71.42% <37.50%> (+71.42%)	⬆️
controllers/vgmanager.go	76.08% <40.00%> (+37.78%)	⬆️
controllers/lvm_volumegroup.go	78.57% <50.00%> (+78.57%)	⬆️
... and 9 more

... and 1 file with indirect coverage changes

[openshift-ci-robot]

@jakobmoellerdev: This pull request references OCPVE-667 which is a valid jira issue.

In response to this:

This allows no default deviceClass to be present. Since this is a change from previous validation it now includes a warning if no default is set: "no default deviceClass was specified, it will be mandatory to specify the storage class"

TODO:

• Test case using no default deviceClass that succeeds in e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@jakobmoellerdev: This pull request references OCPVE-667 which is a valid jira issue.

In response to this:

This allows no default deviceClass to be present. Since this is a change from previous validation it now includes a warning if no default is set: "no default deviceClass was specified, it will be mandatory to specify the storage class"

TODO:

• Test case using no default deviceClass that succeeds in e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jakobmoellerdev]

/test lvm-operator-e2e-aws-sno

[jakobmoellerdev]

/test lvm-operator-e2e-aws-sno

[openshift-ci]

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[suleymanakbas91]

/lgtm

[suleymanakbas91]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment