OCPVE-588: chore: refactor AWS Disk Setup to use correct logs/ctx #394
Conversation
jakobmoellerdev
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@jakobmoellerdev: This pull request references OCPVE-588 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/XXL
|
/hold requires openshift/release#42554 can already be reviewed though. |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test lvm-operator-e2e-aws |
1 similar comment
|
/test lvm-operator-e2e-aws |
|
/hold |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
| fmt.Printf("failed to list nodes\n") | ||
| return err | ||
| if err := crClient.List(ctx, nodeList, client.HasLabels{labelNodeRoleWorker}); err != nil { | ||
| return fmt.Errorf("could not list worker nodes nodes for Disk setup: %w", err) |
There was a problem hiding this comment.
| return fmt.Errorf("could not list worker nodes nodes for Disk setup: %w", err) | |
| return fmt.Errorf("could not list worker nodes for Disk setup: %w", err) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev, suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@jakobmoellerdev: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR upgrades The AWS sdk, refactors the AWS client calls to all use a Context from Before/After Suite in Ginkgo, and passes a structured
logr.Loggerfrom Ginkgo that is-vaware instead of usingfmt.Printlnin the disk setup utility for our AWS scenarios