-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPVE-606: fix: reenable falsly disabled integration tests #373
OCPVE-606: fix: reenable falsly disabled integration tests #373
Conversation
Signed-off-by: jakobmoellerdev <[email protected]>
@jakobmoellerdev: This pull request references OCPVE-606 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jakobmoellerdev: This pull request references OCPVE-606 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
===========================================
+ Coverage 16.59% 56.72% +40.12%
===========================================
Files 24 24
Lines 2061 2061
===========================================
+ Hits 342 1169 +827
+ Misses 1693 809 -884
- Partials 26 83 +57 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev, jeff-roche The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@jakobmoellerdev: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This enables the test suites that were disabled in 3ce11a8 back in may by accident. Potentially the ginkgo logs could cause issues in pipeline parsers if the stdout is parsed, not sure if that changed since then. Other than that it should run fine