Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-406: Cluster builds #365

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

jeff-roche
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 18, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 18, 2023

@jeff-roche: This pull request references OCPVE-406 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-roche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2023
@jeff-roche
Copy link
Contributor Author

/hold for review

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2023
@brandisher
Copy link
Contributor

/lgtm

Keeping the hold for @qJkee's review

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 18, 2023
@brandisher
Copy link
Contributor

Changes are a noop so readding label

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #365 (e602d82) into main (f444ae9) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #365   +/-   ##
=======================================
  Coverage   14.38%   14.38%           
=======================================
  Files          23       23           
  Lines        1932     1932           
=======================================
  Hits          278      278           
  Misses       1630     1630           
  Partials       24       24           

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023
@qJkee
Copy link
Contributor

qJkee commented Jul 19, 2023

/lgtm
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f444ae9 and 2 for PR HEAD 5584041 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

@jeff-roche: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • are
  • e2e
  • manual
  • tests
  • working

Only the following failed contexts/checkruns were expected:

  • ci/prow/ci-index-lvm-operator-static-deps
  • ci/prow/images
  • ci/prow/lvm-operator-bundle-e2e-aws
  • ci/prow/unit-test
  • ci/prow/verify
  • pull-ci-openshift-lvm-operator-main-ci-index-lvm-operator-static-deps
  • pull-ci-openshift-lvm-operator-main-images
  • pull-ci-openshift-lvm-operator-main-lvm-operator-bundle-e2e-aws
  • pull-ci-openshift-lvm-operator-main-unit-test
  • pull-ci-openshift-lvm-operator-main-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ci/prow/lvm-operator-bundle-e2e-aws manual e2e tests are working

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeff-roche
Copy link
Contributor Author

/override ci/prow/lvm-operator-bundle-e2e-aws

manual e2e tests are working

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

@jeff-roche: Overrode contexts on behalf of jeff-roche: ci/prow/lvm-operator-bundle-e2e-aws

In response to this:

/override ci/prow/lvm-operator-bundle-e2e-aws

manual e2e tests are working

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

@jeff-roche: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4275e11 into openshift:main Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants