OCPVE-386: feat: added the optionalPaths device selector field

[jeff-roche]

No description provided.

[openshift-ci-robot]

@jeff-roche: This pull request references OCPVE-386 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-roche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jeff-roche]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jeff-roche]

/hold for review
/cc @brandisher @qJkee

[jeff-roche]

Validated the e2e tests are running successfully manually

[codecov-commenter]

Codecov Report

Merging #364 (2ded83c) into main (f444ae9) will increase coverage by 1.05%.
The diff coverage is 42.55%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
+ Coverage   14.38%   15.44%   +1.05%     
==========================================
  Files          23       23              
  Lines        1932     1988      +56     
==========================================
+ Hits          278      307      +29     
- Misses       1630     1657      +27     
  Partials       24       24              

Impacted Files	Coverage Δ
api/v1alpha1/lvmcluster_types.go	100.00% <ø> (ø)
api/v1alpha1/lvmcluster_webhook.go	0.00% <0.00%> (ø)
pkg/vgmanager/devices.go	72.64% <95.23%> (+9.72%)	⬆️

[brandisher]

Overall this lgtm. The approach makes sense and there are some simple/clever bits of code that satisfy the use case. My feedback is mostly non-blocking suggestions and a couple of questions. I like the consolidation of certain aspects like validateDeviceSelectorPaths().

Putting a hold on for another review.

/lgtm
/hold

[qJkee]

/lgtm

[jeff-roche]

/unhold
/override ci/prow/lvm-operator-bundle-e2e-aws

[openshift-ci]

@jeff-roche: Overrode contexts on behalf of jeff-roche: ci/prow/lvm-operator-bundle-e2e-aws

In response to this:

/unhold
/override ci/prow/lvm-operator-bundle-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jeff-roche: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.