Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-13364: fix: Added a tag for arm64 to have it pulled into Openshift for ARM #340

Merged
merged 1 commit into from
May 10, 2023

Conversation

jeff-roche
Copy link
Contributor

@jeff-roche jeff-roche commented May 10, 2023

This should list the operator in Openshift for ARM as brought up in #335

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 10, 2023
@jeff-roche jeff-roche changed the title fix: Added a tag for arm64 to have it pulled into Openshift for ARM [OCPBUGS-13364] fix: Added a tag for arm64 to have it pulled into Openshift for ARM May 10, 2023
@openshift-ci openshift-ci bot requested review from qJkee and suleymanakbas91 May 10, 2023 14:54
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-roche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #340 (a4e0730) into main (c54c93e) will decrease coverage by 0.28%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
- Coverage   57.10%   56.83%   -0.28%     
==========================================
  Files          21       21              
  Lines        1844     1844              
==========================================
- Hits         1053     1048       -5     
- Misses        714      718       +4     
- Partials       77       78       +1     

see 1 file with indirect coverage changes

@suleymanakbas91
Copy link
Contributor

/lgtm

@suleymanakbas91 suleymanakbas91 changed the title [OCPBUGS-13364] fix: Added a tag for arm64 to have it pulled into Openshift for ARM OCPBUGS-13364: fix: Added a tag for arm64 to have it pulled into Openshift for ARM May 10, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 10, 2023
@openshift-ci-robot
Copy link

@jeff-roche: This pull request references Jira Issue OCPBUGS-13364, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@jeff-roche: This pull request references Jira Issue OCPBUGS-13364, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This should list the operator in Openshift for ARM as brought up in #335

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2023
@jeff-roche
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 10, 2023
@openshift-ci-robot
Copy link

@jeff-roche: This pull request references Jira Issue OCPBUGS-13364, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from radeore May 10, 2023 15:03
@openshift-merge-robot openshift-merge-robot merged commit 28c2928 into openshift:main May 10, 2023
@openshift-ci-robot
Copy link

@jeff-roche: Jira Issue OCPBUGS-13364: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13364 has been moved to the MODIFIED state.

In response to this:

This should list the operator in Openshift for ARM as brought up in #335

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeff-roche jeff-roche deleted the arm64 branch May 10, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants