Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPVE-230: Improve README content #333

Merged
merged 1 commit into from
May 3, 2023
Merged

OCPVE-230: Improve README content #333

merged 1 commit into from
May 3, 2023

Conversation

suleymanakbas91
Copy link
Contributor

@suleymanakbas91 suleymanakbas91 commented Apr 27, 2023 •
edited
Loading

This PRs improves the README content and refactors the docs folder. Follow-up work in #334 improves other docs under the design folder.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 27, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 27, 2023
@suleymanakbas91 suleymanakbas91 force-pushed the refactor-docs branch 5 times, most recently from ea950bc to 3e3864a Compare April 27, 2023 12:39
@suleymanakbas91 suleymanakbas91 changed the title chore: refactor documentation OCPVE-230: Improve README content Apr 27, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 27, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 27, 2023 •
edited by openshift-ci bot
Loading

@suleymanakbas91: This pull request references OCPVE-230 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 27, 2023 •
edited by openshift-ci bot
Loading

@suleymanakbas91: This pull request references OCPVE-230 which is a valid jira issue.

In response to this:

This PRs improves the README content and refactors the docs folder. Follow-up work in https://issues.redhat.com/browse/OCPVE-231 will also improve other docs under the design folder.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@suleymanakbas91 suleymanakbas91 force-pushed the refactor-docs branch 2 times, most recently from 50c10ff to 5a8912d Compare April 27, 2023 12:45
@suleymanakbas91 suleymanakbas91 marked this pull request as ready for review April 27, 2023 12:45
@suleymanakbas91
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 27, 2023
@openshift-ci openshift-ci bot requested review from brandisher and qJkee April 27, 2023 12:46
jeff-roche
jeff-roche reviewed Apr 27, 2023
View reviewed changes
@jeff-roche
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2023
aireilly
aireilly reviewed May 2, 2023
View reviewed changes
Copy link

@aireilly aireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added some comments. Check https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#general-references for further guidance.

@suleymanakbas91 suleymanakbas91 force-pushed the refactor-docs branch 2 times, most recently from c82f062 to 4350f44 Compare May 2, 2023 12:02
@suleymanakbas91 suleymanakbas91 force-pushed the refactor-docs branch 5 times, most recently from d8554e6 to 0409437 Compare May 2, 2023 12:22
@suleymanakbas91
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2023
aireilly
aireilly approved these changes May 3, 2023
View reviewed changes
Copy link

@aireilly aireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - left a few small comments :)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aireilly, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@suleymanakbas91
chore: improve README content
1f89479 
Signed-off-by: Suleyman Akbas <[email protected]>
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 3, 2023 •
edited by openshift-ci bot
Loading

@suleymanakbas91: This pull request references OCPVE-230 which is a valid jira issue.

In response to this:

This PRs improves the README content and refactors the docs folder. Follow-up work in #334 improves other docs under the design folder.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeff-roche
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit 24e61fc into openshift:main May 3, 2023
@suleymanakbas91 suleymanakbas91 deleted the refactor-docs branch May 3, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-roche jeff-roche jeff-roche left review comments

@aireilly aireilly aireilly approved these changes

@brandisher brandisher Awaiting requested review from brandisher

@qJkee qJkee Awaiting requested review from qJkee

Assignees

@jeff-roche jeff-roche

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@suleymanakbas91 @openshift-ci-robot @jeff-roche @aireilly @openshift-merge-robot