-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPVE-187: Add Chad, Jeremy, and Suleyman to the OWNERS #297
Conversation
Hi @suleymanakbas91. Thanks for your PR. I'm waiting for a red-hat-storage member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@suleymanakbas91 , please include a Signed-off-by line in the commit msg. chore: add additional owners Add Chad, Jeremy, and Suleyman to OWNERS Signed-off-by : |
3fe5a1e
to
01ec7f0
Compare
Sure, I've done it. Is there any particular reason why you're signing off all the commits or is it just for keeping a consistent record of commits? |
/test all |
/verify-owners |
1 similar comment
/verify-owners |
Add Chad, Jeremy, and Suleyman to OWNERS Signed-off-by: Suleyman Akbas <[email protected]>
01ec7f0
to
2cf8d30
Compare
New changes are detected. LGTM label has been removed. |
@nbalacha could you please re-approve? :) |
/approve /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nbalacha, suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As a part of ownership transitioning efforts, this PR adds @brandisher, @jerpeter1, and @suleymanakbas91 to the OWNERS.