Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-187: Add Chad, Jeremy, and Suleyman to the OWNERS #297

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

suleymanakbas91
Copy link
Contributor

As a part of ownership transitioning efforts, this PR adds @brandisher, @jerpeter1, and @suleymanakbas91 to the OWNERS.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2022

Hi @suleymanakbas91. Thanks for your PR.

I'm waiting for a red-hat-storage member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 30, 2022
@nbalacha
Copy link
Contributor

@suleymanakbas91 , please include a Signed-off-by line in the commit msg.
Suggested commit msg:

chore: add additional owners

Add Chad, Jeremy, and Suleyman to OWNERS

Signed-off-by :

@suleymanakbas91
Copy link
Contributor Author

@suleymanakbas91 , please include a Signed-off-by line in the commit msg. Suggested commit msg:

chore: add additional owners

Add Chad, Jeremy, and Suleyman to OWNERS

Signed-off-by :

Sure, I've done it. Is there any particular reason why you're signing off all the commits or is it just for keeping a consistent record of commits?

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 1, 2022
@suleymanakbas91
Copy link
Contributor Author

/test all

@suleymanakbas91
Copy link
Contributor Author

/verify-owners

1 similar comment
@suleymanakbas91
Copy link
Contributor Author

/verify-owners

@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Dec 6, 2022
Add Chad, Jeremy, and Suleyman to OWNERS

Signed-off-by: Suleyman Akbas <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2022

New changes are detected. LGTM label has been removed.

@suleymanakbas91
Copy link
Contributor Author

@nbalacha could you please re-approve? :)

@nbalacha
Copy link
Contributor

nbalacha commented Dec 6, 2022

/approve /lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nbalacha, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nbalacha nbalacha merged commit 2adbb8f into openshift:main Dec 6, 2022
@suleymanakbas91 suleymanakbas91 deleted the owners branch December 7, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants