Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topolvm.io name changes #293

Merged
merged 4 commits into from
Nov 22, 2022
Merged

Conversation

nbalacha
Copy link
Contributor

This PR contains the changes required for the LVM operator to work with the new TopoLVM group name topolvm.io.

@nbalacha nbalacha requested a review from iamniting November 16, 2022 16:21
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2022

@nbalacha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lvm-operator-bundle-e2e-aws b34b8a3 link false /test lvm-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kind: Kustomization
images:
- name: controller
newName: quay.io/nibalach/lvm-operator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed as it contains personal registry

@@ -1,5 +1,5 @@
OPERATOR_NAMESPACE=openshift-storage
TOPOLVM_CSI_IMAGE=quay.io/ocs-dev/topolvm:latest
TOPOLVM_CSI_IMAGE=quay.io/nibalach/topolvm:16nov-1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sam here

Changes required to use TopoLVM with the new
group name topolvm.io.

Signed-off-by: N Balachandran <[email protected]>
This commit updates the bundle manifests with the changes
required for the new TopoLVM group name topolvm.io.

Signed-off-by: N Balachandran <[email protected]>
Replaces topolvm.cybozu.com with topolvm.io in the
docs.

Signed-off-by: N Balachandran <[email protected]>
Updates the vendor directory.

Signed-off-by: N Balachandran <[email protected]>
Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, nbalacha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9fbd851 into openshift:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants