-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topolvm.io name changes #293
Conversation
@nbalacha: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
config/manager/kustomization.yaml
Outdated
kind: Kustomization | ||
images: | ||
- name: controller | ||
newName: quay.io/nibalach/lvm-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be removed as it contains personal registry
config/manager/manager.env
Outdated
@@ -1,5 +1,5 @@ | |||
OPERATOR_NAMESPACE=openshift-storage | |||
TOPOLVM_CSI_IMAGE=quay.io/ocs-dev/topolvm:latest | |||
TOPOLVM_CSI_IMAGE=quay.io/nibalach/topolvm:16nov-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sam here
Changes required to use TopoLVM with the new group name topolvm.io. Signed-off-by: N Balachandran <[email protected]>
This commit updates the bundle manifests with the changes required for the new TopoLVM group name topolvm.io. Signed-off-by: N Balachandran <[email protected]>
Replaces topolvm.cybozu.com with topolvm.io in the docs. Signed-off-by: N Balachandran <[email protected]>
Updates the vendor directory. Signed-off-by: N Balachandran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, nbalacha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR contains the changes required for the LVM operator to work with the new TopoLVM group name topolvm.io.