Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for multiple LVMCluster instances #241

Merged
merged 1 commit into from
Aug 22, 2022
Merged

fix: check for multiple LVMCluster instances #241

merged 1 commit into from
Aug 22, 2022

Conversation

nbalacha
Copy link
Contributor

@nbalacha nbalacha commented Aug 18, 2022

The operator requires that only a single instance of the
LVMCluster exists on the cluster.This fix fails the reconciliation
if the operator finds multiple LVMCluster instances on the cluster.

Fixes #240

Signed-off-by: N Balachandran [email protected]

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2022
The operator requires that only a single instance of the
LVMCluster exists on the cluster.This fix fails the reconciliation
if the operator finds multiple LVMCluster instances on the cluster.

Signed-off-by: N Balachandran <[email protected]>
@riya-singhal31
Copy link
Contributor

The changes looks good.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nbalacha, riya-singhal31

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nbalacha
Copy link
Contributor Author

/retest

@nbalacha nbalacha merged commit 06dd6b9 into openshift:main Aug 22, 2022
@nbalacha nbalacha deleted the clean-1 branch September 6, 2022 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LVMO should only allow a single LVMCluster instance.
2 participants