Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: github action to build the operator every week #198

Merged
merged 1 commit into from
May 30, 2022
Merged

chore: github action to build the operator every week #198

merged 1 commit into from
May 30, 2022

Conversation

nbalacha
Copy link
Contributor

This adds a github action to build and push the operator
image to quay every Monday.

Signed-off-by: N Balachandran [email protected]

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2022
@nbalacha
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2022

- uses: actions/checkout@v2

# 'test' is a sub-target of 'docker-build' and so cache go build & mod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's test over here?

Copy link
Contributor Author

@nbalacha nbalacha May 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make docker-build-combined runs a make test automatically.

@@ -0,0 +1,51 @@
name: LVMO Weekly Image Publish

# Run every Monday at 23:00 UTC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Run every Monday at 23:00 UTC
# Runs every Monday at 23:00 UTC

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link

@Yuggupta27 Yuggupta27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, else looks good

run: make docker-build-combined IMG=${{env.IMG}}

- name: Publish operator image
run: docker push IMG=${{env.IMG}}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: docker push IMG=${{env.IMG}}
run: docker push IMG=${{env.IMG}}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

This adds a github action to build and push the operator
image to quay every Monday.

Signed-off-by: N Balachandran <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

@nbalacha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lvm-operator-bundle-e2e-aws 0b56f9d link false /test lvm-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nbalacha, sp98, Yuggupta27

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nbalacha nbalacha merged commit bdb73ef into openshift:main May 30, 2022
@nbalacha nbalacha deleted the weekly-build branch May 30, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants