Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize operator-sdk project, api, and provide reconcile scaffolding. #1

Merged
merged 7 commits into from
Dec 3, 2021

Conversation

rohantmp
Copy link
Contributor

@rohantmp rohantmp commented Dec 2, 2021

No description provided.

@rohantmp
Copy link
Contributor Author

rohantmp commented Dec 2, 2021

@nbalacha , working on more scaffolding and tasks

@rohantmp
Copy link
Contributor Author

rohantmp commented Dec 2, 2021

I'll create empty functions for reconciling the csidrivers, node daemonset (daemon that discovers devices, matches against filters, creates lvmd config), lvmd, etc
I'll then create subtasks for each of these that can be picked up.

Copy link

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please not vendor unless we really need to? Thanks!

@leelavg
Copy link
Contributor

leelavg commented Dec 2, 2021

- reg deployment model of CSI controller and nodeplugin


node daemonset (daemon that discovers devices, matches against filters, creates lvmd config)

  • will we be following similar design of deploying lvmd and nodeplugin as deployment
  • there's no way out of it, so just confirming if you thought of any other design

  • there's a possibility to deploy lvmd and nodeplugin as daemonset if we can maintain a single lvmd configmap, however it may go over 1MB limit
  • that requires a change to topolvm code, mainly in the lvmd to wait for the availability of VG

my query is, as we aren't accepting the topolvm version/image from the CR how best we can deploy underlying CSI controller and nodeplugin with sidecars and possibility of getting away with using a single manager for multiple controllers?

@rohantmp rohantmp changed the title Initialize operator-sdk project and api Initialize operator-sdk project, api, and provide reconcile scaffolding. Dec 2, 2021
@nbalacha
Copy link
Contributor

nbalacha commented Dec 2, 2021

- reg deployment model of CSI controller and nodeplugin

node daemonset (daemon that discovers devices, matches against filters, creates lvmd config)

  • will we be following similar design of deploying lvmd and nodeplugin as deployment

  • there's no way out of it, so just confirming if you thought of any other design

  • there's a possibility to deploy lvmd and nodeplugin as daemonset if we can maintain a single lvmd configmap, however it may go over 1MB limit

  • that requires a change to topolvm code, mainly in the lvmd to wait for the availability of VG

my query is, as we aren't accepting the topolvm version/image from the CR how best we can deploy underlying CSI controller and nodeplugin with sidecars and possibility of getting away with using a single manager for multiple controllers?

We can use env variables to specify the images for now and the topolvm controller can also watch the operator config map.

Result of running

'operator-sdk init --domain topolvm.io --repo github.com/red-hat-storage/lvm-operator --project-name lvm-operator --license apache2'

Signed-off-by: Rohan CJ <[email protected]>
Result of running:

'operator-sdk create api --group lvm --version v1alpha1 --kind LVMCluster'

Signed-off-by: Rohan CJ <[email protected]>
@rohantmp
Copy link
Contributor Author

rohantmp commented Dec 3, 2021

will we be following similar design of deploying lvmd and nodeplugin as deployment
there's no way out of it, so just confirming if you thought of any other design

@leelavg We could avoid having the lvmd config as a configmap and simply have it live on the node. Each node's daemon could generate it based on existing config and logic.

@rohantmp
Copy link
Contributor Author

rohantmp commented Dec 3, 2021

Have updated the scaffolding

@nbalacha nbalacha merged commit 4f4f7b5 into openshift:main Dec 3, 2021
copejon pushed a commit to copejon/lvm-operator that referenced this pull request Oct 31, 2024
Add hack script to deploy kubesan under openshift-storage namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants